Commit dd404929 authored by shend's avatar shend Committed by Commit bot

Generate enum/getters/setters/mappings for text-security.

Currently, the text-security property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the EWordBreak enum and use the generated
CSSValueID <-> EWordBreak mappings.

Diff of generated files:
https://gist.github.com/darrnshn/2811407420cd06be91eca37e52c974d6/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2911583002
Cr-Commit-Position: refs/heads/master@{#474901}
parent 78f5c551
......@@ -1275,44 +1275,6 @@ inline TextDecorationSkip CSSIdentifierValue::ConvertTo() const {
return TextDecorationSkip::kObjects;
}
template <>
inline CSSIdentifierValue::CSSIdentifierValue(ETextSecurity e)
: CSSValue(kIdentifierClass) {
switch (e) {
case ETextSecurity::kNone:
value_id_ = CSSValueNone;
break;
case ETextSecurity::kDisc:
value_id_ = CSSValueDisc;
break;
case ETextSecurity::kCircle:
value_id_ = CSSValueCircle;
break;
case ETextSecurity::kSquare:
value_id_ = CSSValueSquare;
break;
}
}
template <>
inline ETextSecurity CSSIdentifierValue::ConvertTo() const {
switch (value_id_) {
case CSSValueNone:
return ETextSecurity::kNone;
case CSSValueDisc:
return ETextSecurity::kDisc;
case CSSValueCircle:
return ETextSecurity::kCircle;
case CSSValueSquare:
return ETextSecurity::kSquare;
default:
break;
}
NOTREACHED();
return ETextSecurity::kNone;
}
template <>
inline CSSIdentifierValue::CSSIdentifierValue(EUserDrag e)
: CSSValue(kIdentifierClass) {
......
......@@ -2597,10 +2597,9 @@
{
name: "-webkit-text-security",
inherited: true,
field_template: "storage_only",
type_name: "ETextSecurity",
default_value: "ETextSecurity::kNone",
field_size: 2,
field_template: "keyword",
keywords: ["none", "disc", "circle", "square"],
default_value: "none",
field_group: "rare-inherited",
},
{
......
......@@ -173,8 +173,6 @@ enum EFlexDirection {
};
enum EFlexWrap { kFlexNoWrap, kFlexWrap, kFlexWrapReverse };
enum class ETextSecurity { kNone, kDisc, kCircle, kSquare };
// CSS3 User Modify Properties
enum class EUserModify { kReadOnly, kReadWrite, kReadWritePlaintextOnly };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment