Commit dd8383aa authored by peconn's avatar peconn Committed by Commit bot

Remove android_support_annotations target.

android-support-annotations.jar and android-support-v13.jar both define android.support.annotations. Since we use both, this can produce errors building when we try to use android.support.annotations in a new target (eg com.android.dex.DexException: Multiple dex files define Landroid/support/annotation/AnimRes).

android-support-annotations.jar contains a subset of android-support-v13.jar, so I am removing it and updating all dependencies to point to the latter.

BUG=623012

Review-Url: https://codereview.chromium.org/2137433002
Cr-Commit-Position: refs/heads/master@{#404371}
parent 1a552c0e
...@@ -56,10 +56,6 @@ android_java_prebuilt("android_support_design_java") { ...@@ -56,10 +56,6 @@ android_java_prebuilt("android_support_design_java") {
jar_path = "$android_sdk_root/extras/android/support/design/libs/android-support-design.jar" jar_path = "$android_sdk_root/extras/android/support/design/libs/android-support-design.jar"
} }
android_java_prebuilt("android_support_annotations_javalib") {
jar_path = "$android_sdk_root/extras/android/support/annotations/android-support-annotations.jar"
}
java_prebuilt("android_support_multidex_java") { java_prebuilt("android_support_multidex_java") {
supports_android = true supports_android = true
jar_path = "$android_sdk_root/extras/android/support/multidex/library/libs/android-support-multidex.jar" jar_path = "$android_sdk_root/extras/android/support/multidex/library/libs/android-support-multidex.jar"
......
...@@ -250,7 +250,7 @@ ...@@ -250,7 +250,7 @@
'cronet_version', 'cronet_version',
'load_states_list', 'load_states_list',
'network_quality_observation_source_java', 'network_quality_observation_source_java',
'../third_party/android_tools/android_tools.gyp:android_support_annotations_javalib', '../third_party/android_tools/android_tools.gyp:android_support_v13_java',
], ],
'variables': { 'variables': {
'java_in_dir': 'cronet/android/api', 'java_in_dir': 'cronet/android/api',
...@@ -269,7 +269,7 @@ ...@@ -269,7 +269,7 @@
'libcronet', 'libcronet',
'net_request_priority_java', 'net_request_priority_java',
'network_quality_observation_source_java', 'network_quality_observation_source_java',
'../third_party/android_tools/android_tools.gyp:android_support_annotations_javalib', '../third_party/android_tools/android_tools.gyp:android_support_v13_java',
], ],
'variables': { 'variables': {
'java_in_dir': 'cronet/android/java', 'java_in_dir': 'cronet/android/java',
......
...@@ -274,7 +274,7 @@ android_library("cronet_api") { ...@@ -274,7 +274,7 @@ android_library("cronet_api") {
] ]
deps = [ deps = [
"//third_party/android_tools:android_support_annotations_javalib", "//third_party/android_tools:android_support_v13_java",
] ]
srcjar_deps = [ srcjar_deps = [
...@@ -313,7 +313,7 @@ android_library("cronet_java") { ...@@ -313,7 +313,7 @@ android_library("cronet_java") {
":cronet_api", ":cronet_api",
"//base:base_java", "//base:base_java",
"//net/android:net_java", "//net/android:net_java",
"//third_party/android_tools:android_support_annotations_javalib", "//third_party/android_tools:android_support_v13_java",
"//third_party/jsr-305:jsr_305_javalib", "//third_party/jsr-305:jsr_305_javalib",
] ]
......
...@@ -10,7 +10,7 @@ android_library("android_async_task_java") { ...@@ -10,7 +10,7 @@ android_library("android_async_task_java") {
java_files = [ "java/src/org/chromium/third_party/android/os/AsyncTask.java" ] java_files = [ "java/src/org/chromium/third_party/android/os/AsyncTask.java" ]
deps = [ deps = [
"//base:base_java", "//base:base_java",
"//third_party/android_tools:android_support_annotations_javalib", "//third_party/android_tools:android_support_v13_java",
] ]
chromium_code = false chromium_code = false
} }
...@@ -11,4 +11,4 @@ This contains a copy of Android sdk 23's AsyncTask.java. ...@@ -11,4 +11,4 @@ This contains a copy of Android sdk 23's AsyncTask.java.
Local Modifications: Local Modifications:
- Renamed package to org.chromium.third_party.android.os. - Renamed package to org.chromium.third_party.android.os.
- Explicitly import android.os objects. - Explicitly import android.os objects.
- Switch to using android.support.annotations. - Switch to using android.support.annotations (from android.support.v13).
...@@ -16,7 +16,7 @@ android_java_prebuilt("espresso_contrib_java") { ...@@ -16,7 +16,7 @@ android_java_prebuilt("espresso_contrib_java") {
android_java_prebuilt("espresso_core_java") { android_java_prebuilt("espresso_core_java") {
jar_path = "lib/espresso-core-2.2-release-no-dep.jar" jar_path = "lib/espresso-core-2.2-release-no-dep.jar"
deps = [ deps = [
"//third_party/android_tools:android_support_annotations_javalib", "//third_party/android_tools:android_support_v13_java",
"//third_party/guava:guava_java", "//third_party/guava:guava_java",
"//third_party/hamcrest:hamcrest_core_java", "//third_party/hamcrest:hamcrest_core_java",
"//third_party/javax_inject:javax_inject_java", "//third_party/javax_inject:javax_inject_java",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment