Commit dda77484 authored by Jesse Selover's avatar Jesse Selover Committed by Commit Bot

Clean up LOAD_DO_NOT_SEND_COOKIES requests.

This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load
flags and replace them with the allow_credentials setting. See
https://crbug.com/799935,
https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4,
and
go/allow-credentials-tracker
for the motivation and progress of this change.

This is the only place where a request is configured with
LOAD_DO_NOT_SEND_COOKIES without either of the other two load flags. The
request currently saves cookies, but doesn't send them.
I've conservatively put allow_credentials = true on this request, which will
cause the saved cookies to be sent. If your service doesn't require cookies
then it should be allow_credentials = false.

Bug: 799935
Change-Id: Ibd435acc810359482ec97d633637e42dc53923a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600546
Commit-Queue: Jesse Selover <jselover@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Jesse Selover <jselover@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660966}
parent 5ff2d1be
......@@ -155,8 +155,8 @@ void PrivetURLLoader::Try() {
request->url = url_;
request->method = request_type_;
// Privet requests are relevant to hosts on local network only.
request->load_flags = net::LOAD_BYPASS_PROXY | net::LOAD_DISABLE_CACHE |
net::LOAD_DO_NOT_SEND_COOKIES;
request->load_flags = net::LOAD_BYPASS_PROXY | net::LOAD_DISABLE_CACHE;
request->allow_credentials = false;
std::string token = GetPrivetAccessToken();
if (token.empty())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment