Commit ddbee033 authored by dmazzoni's avatar dmazzoni Committed by Commit bot

Add more logging to debug DumpAccessibilityEvent* test failures

BUG=440579
TBR=thakis

Review URL: https://codereview.chromium.org/867483008

Cr-Commit-Position: refs/heads/master@{#313753}
parent 0d96f15b
...@@ -76,15 +76,22 @@ IAccessible* BrowserAccessibilityManagerWin::GetParentIAccessible() { ...@@ -76,15 +76,22 @@ IAccessible* BrowserAccessibilityManagerWin::GetParentIAccessible() {
void BrowserAccessibilityManagerWin::MaybeCallNotifyWinEvent( void BrowserAccessibilityManagerWin::MaybeCallNotifyWinEvent(
DWORD event, BrowserAccessibility* node) { DWORD event, BrowserAccessibility* node) {
BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager(); BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager();
if (!delegate) if (!delegate) {
// This line and other LOG(WARNING) lines are temporary, to debug
// flaky failures in DumpAccessibilityEvent* tests.
// http://crbug.com/440579
LOG(WARNING) << "Not firing AX event because of no delegate";
return; return;
}
if (!node->IsNative()) if (!node->IsNative())
return; return;
HWND hwnd = delegate->AccessibilityGetAcceleratedWidget(); HWND hwnd = delegate->AccessibilityGetAcceleratedWidget();
if (!hwnd) if (!hwnd) {
LOG(WARNING) << "Not firing AX event because of no hwnd";
return; return;
}
// Inline text boxes are an internal implementation detail, we don't // Inline text boxes are an internal implementation detail, we don't
// expose them to Windows. // expose them to Windows.
...@@ -176,8 +183,10 @@ void BrowserAccessibilityManagerWin::NotifyAccessibilityEvent( ...@@ -176,8 +183,10 @@ void BrowserAccessibilityManagerWin::NotifyAccessibilityEvent(
ui::AXEvent event_type, ui::AXEvent event_type,
BrowserAccessibility* node) { BrowserAccessibility* node) {
BrowserAccessibilityDelegate* root_delegate = GetDelegateFromRootManager(); BrowserAccessibilityDelegate* root_delegate = GetDelegateFromRootManager();
if (!root_delegate || !root_delegate->AccessibilityGetAcceleratedWidget()) if (!root_delegate || !root_delegate->AccessibilityGetAcceleratedWidget()) {
LOG(WARNING) << "Not firing AX event because of no root_delegate or hwnd";
return; return;
}
// Inline text boxes are an internal implementation detail, we don't // Inline text boxes are an internal implementation detail, we don't
// expose them to Windows. // expose them to Windows.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment