DevTools: CPUFlameChart: stick function entry color to the function name and url.

The old color generator had the dependency from line number too and it was a bad idea because
after a change in the source file the entry would change the color.

Also the entry colors had implicit dependency from the order of processing.

BUG=382116
R=alph@chromium.org

Review URL: https://codereview.chromium.org/319363002

git-svn-id: svn://svn.chromium.org/blink/trunk@175787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/devtools/front_end/components/FlameChart.js

@@ -232,7 +232,6 @@ WebInspector.FlameChart.ColorGenerator = function(hueSpace, satSpace, lightnessS
     this._satSpace = satSpace || 67;
     this._lightnessSpace = lightnessSpace || 80;
     this._colors = {};
-    this._currentColorIndex = 0;
 }
 
 WebInspector.FlameChart.ColorGenerator.prototype = {
@@ -253,21 +252,22 @@ WebInspector.FlameChart.ColorGenerator.prototype = {
     {
         var color = this._colors[id];
         if (!color) {
-            color = this._createColor(this._currentColorIndex++);
+            color = this._generateColorForID(id);
             this._colors[id] = color;
         }
         return color;
     },
 
     /**
-     * @param {number} index
+     * @param {string} id
      * @return {string}
      */
-    _createColor: function(index)
+    _generateColorForID: function(id)
     {
-        var h = this._indexToValueInSpace(index, this._hueSpace);
-        var s = this._indexToValueInSpace(index, this._satSpace);
-        var l = this._indexToValueInSpace(index, this._lightnessSpace);
+        var hash = id.hashCode();
+        var h = this._indexToValueInSpace(hash, this._hueSpace);
+        var s = this._indexToValueInSpace(hash, this._satSpace);
+        var l = this._indexToValueInSpace(hash, this._lightnessSpace);
         return "hsl(" + h + ", " + s + "%, " + l + "%)";
     },
 
@@ -281,7 +281,7 @@ WebInspector.FlameChart.ColorGenerator.prototype = {
         if (typeof space === "number")
             return space;
         index %= space.count;
-        return space.min + index / space.count * (space.max - space.min);
+        return space.min + Math.floor(index / space.count * (space.max - space.min));
     }
 }
 

third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

@@ -276,7 +276,7 @@ WebInspector.CPUFlameChartDataProvider.prototype = {
     entryColor: function(entryIndex)
     {
         var node = this._entryNodes[entryIndex];
-        return this._colorGenerator.colorForID(node.functionName + ":" + node.url + ":" + node.lineNumber);
+        return this._colorGenerator.colorForID(node.functionName + ":" + node.url);
     },
 
     /**
@@ -342,10 +342,13 @@ WebInspector.CPUFlameChartDataProvider.prototype = {
 WebInspector.CPUFlameChartDataProvider.colorGenerator = function()
 {
     if (!WebInspector.CPUFlameChartDataProvider._colorGenerator) {
-        var colorGenerator = new WebInspector.FlameChart.ColorGenerator();
-        colorGenerator.setColorForID("(idle)::0", "hsl(0, 0%, 94%)");
-        colorGenerator.setColorForID("(program)::0", "hsl(0, 0%, 80%)");
-        colorGenerator.setColorForID("(garbage collector)::0", "hsl(0, 0%, 80%)");
+        var colorGenerator = new WebInspector.FlameChart.ColorGenerator(
+            { min: 180, max: 310, count: 7 },
+            { min: 50, max: 80, count: 5 },
+            { min: 80, max: 90, count: 3 });
+        colorGenerator.setColorForID("(idle):", "hsl(0, 0%, 94%)");
+        colorGenerator.setColorForID("(program):", "hsl(0, 0%, 80%)");
+        colorGenerator.setColorForID("(garbage collector):", "hsl(0, 0%, 80%)");
         WebInspector.CPUFlameChartDataProvider._colorGenerator = colorGenerator;
     }
     return WebInspector.CPUFlameChartDataProvider._colorGenerator;