Makes us compile mojo_view_manager_lib_unittests

We previously weren't.

BUG=none
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1147093002

Cr-Commit-Position: refs/heads/master@{#330792}

components/view_manager/BUILD.gn

@@ -111,8 +111,16 @@ source_set("test_support") {
   ]
 }
 
-test("tests") {
-  output_name = "view_manager_unittests"
+group("tests") {
+  testonly = true
+  deps = [
+    ":apptests",
+    ":view_manager_unittests",
+    "//components/view_manager/public/cpp/tests:mojo_view_manager_lib_unittests",
+  ]
+}
+
+test("view_manager_unittests") {
   sources = [
     "animation_runner_unittest.cc",
     "focus_controller_unittest.cc",

components/view_manager/public/cpp/tests/BUILD.gn

@@ -16,16 +16,12 @@ test("mojo_view_manager_lib_unittests") {
   deps = [
     "//base",
     "//base/test:test_support",
-
-    # TODO(vtl): These non-public deps are illegal here. This should be
-    # converted to an apptest.
+    "//components/view_manager/public/cpp",
     "//mojo/application/public/cpp",
-    "//mojo/edk/system",
-    "//mojo/public/cpp/system",
-    "//mojo/services/geometry/public/cpp",
-    "//mojo/services/geometry/public/interfaces",
-    "//mojo/services/view_manager/public/cpp",
     "//testing/gtest",
+    "//third_party/mojo/src/mojo/public/cpp/system",
+    "//third_party/mojo/src/mojo/edk/system",
+    "//ui/mojo/geometry:interfaces",
   ]
 
   if (use_x11) {

components/view_manager/public/cpp/tests/run_all_unittests.cc

@@ -9,6 +9,7 @@
 int main(int argc, char** argv) {
   mojo::ViewManagerTestSuite test_suite(argc, argv);
 
-  return base::LaunchUnitTests(
-      argc, argv, base::Bind(&TestSuite::Run, base::Unretained(&test_suite)));
+  return base::LaunchUnitTests(argc, argv,
+                               base::Bind(&mojo::ViewManagerTestSuite::Run,
+                                          base::Unretained(&test_suite)));
 }

mandoline/BUILD.gn

@@ -29,7 +29,6 @@ group("tests") {
       "//components/html_viewer:tests",
       "//components/resource_provider:apptests",
       "//components/resource_provider:tests",
-      "//components/view_manager:apptests",
       "//components/view_manager:tests",
     ]
   }