Commit ddec41e5 authored by xiyuan@chromium.org's avatar xiyuan@chromium.org

Remove feedback debugging log.

Removing as bug http://crbug.com/284662 is fixed.

BUG=284662

Review URL: https://codereview.chromium.org/469213008

Cr-Commit-Position: refs/heads/master@{#290068}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290068 0039d316-1c4b-4281-b951-d872f2087c98
parent 6777597b
...@@ -68,8 +68,6 @@ void FeedbackPrivateAPI::RequestFeedback( ...@@ -68,8 +68,6 @@ void FeedbackPrivateAPI::RequestFeedback(
const std::string& description_template, const std::string& description_template,
const std::string& category_tag, const std::string& category_tag,
const GURL& page_url) { const GURL& page_url) {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
LOG(WARNING) << "FEEDBACK_DEBUG: Feedback requested.";
if (browser_context_ && EventRouter::Get(browser_context_)) { if (browser_context_ && EventRouter::Get(browser_context_)) {
FeedbackInfo info; FeedbackInfo info;
info.description = description_template; info.description = description_template;
...@@ -88,8 +86,6 @@ void FeedbackPrivateAPI::RequestFeedback( ...@@ -88,8 +86,6 @@ void FeedbackPrivateAPI::RequestFeedback(
feedback_private::OnFeedbackRequested::kEventName, args.Pass())); feedback_private::OnFeedbackRequested::kEventName, args.Pass()));
event->restrict_to_browser_context = browser_context_; event->restrict_to_browser_context = browser_context_;
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
LOG(WARNING) << "FEEDBACK_DEBUG: Dispatching onFeedbackRequested event.";
EventRouter::Get(browser_context_) EventRouter::Get(browser_context_)
->DispatchEventToExtension(kFeedbackExtensionId, event.Pass()); ->DispatchEventToExtension(kFeedbackExtensionId, event.Pass());
} }
...@@ -135,8 +131,6 @@ bool FeedbackPrivateGetStringsFunction::RunSync() { ...@@ -135,8 +131,6 @@ bool FeedbackPrivateGetStringsFunction::RunSync() {
} }
bool FeedbackPrivateGetUserEmailFunction::RunSync() { bool FeedbackPrivateGetUserEmailFunction::RunSync() {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
LOG(WARNING) << "FEEDBACK_DEBUG: User e-mail requested.";
FeedbackService* service = FeedbackService* service =
FeedbackPrivateAPI::GetFactoryInstance()->Get(GetProfile())->GetService(); FeedbackPrivateAPI::GetFactoryInstance()->Get(GetProfile())->GetService();
DCHECK(service); DCHECK(service);
...@@ -145,8 +139,6 @@ bool FeedbackPrivateGetUserEmailFunction::RunSync() { ...@@ -145,8 +139,6 @@ bool FeedbackPrivateGetUserEmailFunction::RunSync() {
} }
bool FeedbackPrivateGetSystemInformationFunction::RunAsync() { bool FeedbackPrivateGetSystemInformationFunction::RunAsync() {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
LOG(WARNING) << "FEEDBACK_DEBUG: System information requested.";
FeedbackService* service = FeedbackService* service =
FeedbackPrivateAPI::GetFactoryInstance()->Get(GetProfile())->GetService(); FeedbackPrivateAPI::GetFactoryInstance()->Get(GetProfile())->GetService();
DCHECK(service); DCHECK(service);
......
...@@ -67,8 +67,6 @@ function senderWhitelisted(id) { ...@@ -67,8 +67,6 @@ function senderWhitelisted(id) {
*/ */
function feedbackReadyHandler(request, sender, sendResponse) { function feedbackReadyHandler(request, sender, sendResponse) {
if (request.ready) { if (request.ready) {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: FeedbackUI Ready. Sending feedbackInfo.');
chrome.runtime.sendMessage( chrome.runtime.sendMessage(
{sentFromEventPage: true, data: initialFeedbackInfo}); {sentFromEventPage: true, data: initialFeedbackInfo});
} }
...@@ -92,8 +90,6 @@ function requestFeedbackHandler(request, sender, sendResponse) { ...@@ -92,8 +90,6 @@ function requestFeedbackHandler(request, sender, sendResponse) {
*/ */
function startFeedbackUI(feedbackInfo) { function startFeedbackUI(feedbackInfo) {
initialFeedbackInfo = feedbackInfo; initialFeedbackInfo = feedbackInfo;
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: Received onFeedbackRequested. Creating Window.');
chrome.app.window.create('html/default.html', { chrome.app.window.create('html/default.html', {
frame: 'none', frame: 'none',
id: 'default_window', id: 'default_window',
......
...@@ -244,23 +244,15 @@ function resizeAppWindow() { ...@@ -244,23 +244,15 @@ function resizeAppWindow() {
* .) Screenshot taken -> . Show Feedback window. * .) Screenshot taken -> . Show Feedback window.
*/ */
function initialize() { function initialize() {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: feedback.js: initialize()');
// Add listener to receive the feedback info object. // Add listener to receive the feedback info object.
chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) { chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {
if (request.sentFromEventPage) { if (request.sentFromEventPage) {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: Received feedbackInfo.');
feedbackInfo = request.data; feedbackInfo = request.data;
$('description-text').textContent = feedbackInfo.description; $('description-text').textContent = feedbackInfo.description;
if (feedbackInfo.pageUrl) if (feedbackInfo.pageUrl)
$('page-url-text').value = feedbackInfo.pageUrl; $('page-url-text').value = feedbackInfo.pageUrl;
takeScreenshot(function(screenshotCanvas) { takeScreenshot(function(screenshotCanvas) {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: Taken screenshot. Showing window.');
// We've taken our screenshot, show the feedback page without any // We've taken our screenshot, show the feedback page without any
// further delay. // further delay.
window.webkitRequestAnimationFrame(function() { window.webkitRequestAnimationFrame(function() {
...@@ -320,8 +312,6 @@ function initialize() { ...@@ -320,8 +312,6 @@ function initialize() {
}); });
window.addEventListener('DOMContentLoaded', function() { window.addEventListener('DOMContentLoaded', function() {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: feedback.js: DOMContentLoaded');
// Ready to receive the feedback object. // Ready to receive the feedback object.
chrome.runtime.sendMessage({ready: true}); chrome.runtime.sendMessage({ready: true});
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment