Commit ddf061b2 authored by satorux@chromium.org's avatar satorux@chromium.org

gdata: Fix a bug that caused histograms on gdata files to be skewed.

We shouldn't record the histograms when processing delta feeds.

BUG=129248
TEST=manually confirmed by chrome://histograms

Review URL: https://chromiumcodereview.appspot.com/10416049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138394 0039d316-1c4b-4281-b951-d872f2087c98
parent e2a23785
...@@ -3648,11 +3648,14 @@ base::PlatformFileError GDataFileSystem::UpdateFromFeed( ...@@ -3648,11 +3648,14 @@ base::PlatformFileError GDataFileSystem::UpdateFromFeed(
if (should_notify_initial_load) if (should_notify_initial_load)
NotifyInitialLoadFinished(); NotifyInitialLoadFinished();
const int num_total_files = num_hosted_documents + num_regular_files; // Shouldn't record histograms when processing delta feeds.
UMA_HISTOGRAM_COUNTS("GData.NumberOfRegularFiles", num_regular_files); if (!is_delta_feed) {
UMA_HISTOGRAM_COUNTS("GData.NumberOfHostedDocuments", const int num_total_files = num_hosted_documents + num_regular_files;
num_hosted_documents); UMA_HISTOGRAM_COUNTS("GData.NumberOfRegularFiles", num_regular_files);
UMA_HISTOGRAM_COUNTS("GData.NumberOfTotalFiles", num_total_files); UMA_HISTOGRAM_COUNTS("GData.NumberOfHostedDocuments",
num_hosted_documents);
UMA_HISTOGRAM_COUNTS("GData.NumberOfTotalFiles", num_total_files);
}
return base::PLATFORM_FILE_OK; return base::PLATFORM_FILE_OK;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment