Commit ddf1e966 authored by mseaborn@chromium.org's avatar mseaborn@chromium.org

Breakpad test: Fix test disabling logic to refer to the correct flag name

Also disable the test with this flag on 64-bit Windows as well as
32-bit Windows, since we saw a failure on 64-bit Windows too.

BUG=105778
TEST=nacl_integration
TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/11818015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175720 0039d316-1c4b-4281-b951-d872f2087c98
parent 8321b02f
......@@ -42,19 +42,18 @@ if env.Bit('host_windows') or env.Bit('host_mac'):
'--expected_process_type=browser'])
env.AddNodeToTestSuite(
node, ['chrome_browser_tests'], 'run_breakpad_browser_process_crash_test',
# For some strange reason, this test fails on the second run
# (for the SRPC PPAPI proxy) on the Windows XP (32-bit)
# buildbots. The failures modes are that the browser process
# hangs, or that a .dmp file is produced with no .txt file.
# Maybe there is a problem with the command line getting too
# long?
# TODO(mseaborn): Remove this when the "--enable-srpc-proxy"
# For some strange reason, this test sometimes fails on the
# second run (for the SRPC PPAPI proxy) on the Windows 32-bit
# and 64-bit buildbots. The failure modes are that the browser
# process hangs, or that a .dmp file is produced with no .txt
# file. Maybe there is a problem with the command line getting
# too long?
# TODO(mseaborn): Remove this when the "--enable-nacl-srpc-proxy"
# option is removed, or investigate and fix.
is_broken=(env.PPAPIBrowserTesterIsBroken() or
env.Bit('running_on_valgrind') or
(env.Bit('host_windows') and
env.Bit('build_x86_32') and
'--enable-srpc-proxy' in
'--enable-nacl-srpc-proxy' in
os.environ.get('NACL_BROWSER_FLAGS', ''))))
# This crash in trusted code should produce a crash dump.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment