Commit de023766 authored by enne@chromium.org's avatar enne@chromium.org

Turn on the fixed position stacking context flag by default

Because there's an expectation that this flag will need to be reverted on a
branch, add both the enable and the disable flags so that only
web_contents_impl.cc will need to be touched to change the default value.
Both can be removed later, once this setting sticks.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148572 0039d316-1c4b-4281-b951-d872f2087c98
parent a31cf8e6
...@@ -106,6 +106,14 @@ const Experiment::Choice kOmniboxInlineHistoryQuickProviderChoices[] = { ...@@ -106,6 +106,14 @@ const Experiment::Choice kOmniboxInlineHistoryQuickProviderChoices[] = {
switches::kOmniboxInlineHistoryQuickProviderProhibited } switches::kOmniboxInlineHistoryQuickProviderProhibited }
}; };
const Experiment::Choice kFixedPositionCreatesStackingContextChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
switches::kEnableFixedPositionCreatesStackingContext, ""},
{ IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
switches::kDisableFixedPositionCreatesStackingContext, ""}
};
const Experiment::Choice kForceCompositingModeChoices[] = { const Experiment::Choice kForceCompositingModeChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
...@@ -304,7 +312,7 @@ const Experiment kExperiments[] = { ...@@ -304,7 +312,7 @@ const Experiment kExperiments[] = {
IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_NAME, IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_NAME,
IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_DESCRIPTION, IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_DESCRIPTION,
kOsAll, kOsAll,
SINGLE_VALUE_TYPE(switches::kFixedPositionCreatesStackingContext) MULTI_VALUE_TYPE(kFixedPositionCreatesStackingContextChoices)
}, },
// TODO(dspringer): When NaCl is on by default, remove this flag entry. // TODO(dspringer): When NaCl is on by default, remove this flag entry.
{ {
......
...@@ -597,8 +597,8 @@ WebPreferences WebContentsImpl::GetWebkitPrefs(RenderViewHost* rvh, ...@@ -597,8 +597,8 @@ WebPreferences WebContentsImpl::GetWebkitPrefs(RenderViewHost* rvh,
prefs.apply_default_device_scale_factor_in_compositor = true; prefs.apply_default_device_scale_factor_in_compositor = true;
} }
prefs.fixed_position_creates_stacking_context = prefs.fixed_position_creates_stacking_context = !command_line.HasSwitch(
command_line.HasSwitch(switches::kFixedPositionCreatesStackingContext); switches::kDisableFixedPositionCreatesStackingContext);
prefs.number_of_cpu_cores = base::SysInfo::NumberOfProcessors(); prefs.number_of_cpu_cores = base::SysInfo::NumberOfProcessors();
......
...@@ -686,6 +686,9 @@ const char kDefaultTileHeight[] = "default-tile-height"; ...@@ -686,6 +686,9 @@ const char kDefaultTileHeight[] = "default-tile-height";
const char kMaxUntiledLayerWidth[] = "max-untiled-layer-width"; const char kMaxUntiledLayerWidth[] = "max-untiled-layer-width";
const char kMaxUntiledLayerHeight[] = "max-untiled-layer-height"; const char kMaxUntiledLayerHeight[] = "max-untiled-layer-height";
const char kFixedPositionCreatesStackingContext[] const char kEnableFixedPositionCreatesStackingContext[]
= "fixed-position-creates-stacking-context"; = "enable-fixed-position-creates-stacking-context";
const char kDisableFixedPositionCreatesStackingContext[]
= "disable-fixed-position-creates-stacking-context";
} // namespace switches } // namespace switches
...@@ -202,7 +202,8 @@ extern const char kDefaultTileWidth[]; ...@@ -202,7 +202,8 @@ extern const char kDefaultTileWidth[];
extern const char kDefaultTileHeight[]; extern const char kDefaultTileHeight[];
extern const char kMaxUntiledLayerWidth[]; extern const char kMaxUntiledLayerWidth[];
extern const char kMaxUntiledLayerHeight[]; extern const char kMaxUntiledLayerHeight[];
CONTENT_EXPORT extern const char kFixedPositionCreatesStackingContext[]; CONTENT_EXPORT extern const char kEnableFixedPositionCreatesStackingContext[];
CONTENT_EXPORT extern const char kDisableFixedPositionCreatesStackingContext[];
extern const char kEnableVisualWordMovement[]; extern const char kEnableVisualWordMovement[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment