Commit de041368 authored by Aya ElAttar's avatar Aya ElAttar Committed by Commit Bot

Remove TODO comments to update data dsts

Removed TODO(crbug.com/1103614) comments as this
bug is already fixed and all the Clipboard::Read*
references are updated with the proper data destination
objects.

Bug: 1103614
Change-Id: I702d1e9ba5005cba5a3b96e698a5b10b55ec0549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484448
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: default avatarDarwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818622}
parent ec8324c6
......@@ -108,8 +108,6 @@ class COMPONENT_EXPORT(UI_BASE_CLIPBOARD) Clipboard
virtual uint64_t GetSequenceNumber(ClipboardBuffer buffer) const = 0;
// Tests whether the clipboard contains a certain format.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual bool IsFormatAvailable(
const ClipboardFormatType& format,
ClipboardBuffer buffer,
......@@ -133,30 +131,22 @@ class COMPONENT_EXPORT(UI_BASE_CLIPBOARD) Clipboard
// TODO(huangdarwin): Rename to ReadAvailablePortableFormatNames().
// Includes all sanitized types.
// Also, includes pickled types by splitting them out of the pickled format.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originated uses.
virtual void ReadAvailableTypes(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
std::vector<base::string16>* types) const = 0;
// Includes all types, including unsanitized types.
// Omits formats held within pickles, as they're different from what a native
// application would see.
// TODO(crbug.com/1103614): Update |dst| in all references to its appropriate
// ClipboardDataEndpoint for web-originates uses.
virtual std::vector<base::string16> ReadAvailablePlatformSpecificFormatNames(
ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst) const = 0;
// Reads Unicode text from the clipboard, if available.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadText(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
base::string16* result) const = 0;
// Reads ASCII text from the clipboard, if available.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadAsciiText(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
std::string* result) const = 0;
......@@ -165,8 +155,6 @@ class COMPONENT_EXPORT(UI_BASE_CLIPBOARD) Clipboard
// context to parse, |fragment_start| and |fragment_end| are indexes into
// markup indicating the beginning and end of the actual fragment. Otherwise,
// they will contain 0 and markup->size().
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadHTML(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
base::string16* markup,
......@@ -175,15 +163,11 @@ class COMPONENT_EXPORT(UI_BASE_CLIPBOARD) Clipboard
uint32_t* fragment_end) const = 0;
// Reads an SVG image from the clipboard, if available.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadSvg(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
base::string16* result) const = 0;
// Reads RTF from the clipboard, if available. Stores the result as a byte
// vector.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadRTF(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
std::string* result) const = 0;
......@@ -191,14 +175,10 @@ class COMPONENT_EXPORT(UI_BASE_CLIPBOARD) Clipboard
using ReadImageCallback = base::OnceCallback<void(const SkBitmap&)>;
// Reads an image from the clipboard, if available.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadImage(ClipboardBuffer buffer,
const ClipboardDataEndpoint* data_dst,
ReadImageCallback callback) const = 0;
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadCustomData(ClipboardBuffer buffer,
const base::string16& type,
const ClipboardDataEndpoint* data_dst,
......@@ -206,16 +186,12 @@ class COMPONENT_EXPORT(UI_BASE_CLIPBOARD) Clipboard
// Reads a bookmark from the clipboard, if available.
// |title| or |url| may be null.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadBookmark(const ClipboardDataEndpoint* data_dst,
base::string16* title,
std::string* url) const = 0;
// Reads raw data from the clipboard with the given format type. Stores result
// as a byte vector.
// TODO(crbug.com/1103614): Update |data_dst| in all references to its
// appropriate ClipboardDataEndpoint for web-originates uses.
virtual void ReadData(const ClipboardFormatType& format,
const ClipboardDataEndpoint* data_dst,
std::string* result) const = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment