Commit de04887a authored by Luum Habtemariam's avatar Luum Habtemariam Committed by Commit Bot

Re-add deleted base::StringSplitIntoKeyValuePairs unittest

Re-adds the MissingKeyValueDelimiter unittest, accidentally removed in
commit 9268d9a1.

Bug: chromium:894274
Test: Tests still pass.
Change-Id: I37228e812eaf71b1d51fb9982aedea70570311d2
Reviewed-on: https://chromium-review.googlesource.com/c/1306657
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604185}
parent e79ad946
......@@ -91,6 +91,18 @@ TEST_F(SplitStringIntoKeyValuePairsTest, EmptyString) {
EXPECT_TRUE(kv_pairs.empty());
}
TEST_F(SplitStringIntoKeyValuePairsTest, MissingKeyValueDelimiter) {
EXPECT_FALSE(SplitStringIntoKeyValuePairs("key1,key2:value2",
':', // Key-value delimiter
',', // Key-value pair delimiter
&kv_pairs));
ASSERT_EQ(2U, kv_pairs.size());
EXPECT_TRUE(kv_pairs[0].first.empty());
EXPECT_TRUE(kv_pairs[0].second.empty());
EXPECT_EQ("key2", kv_pairs[1].first);
EXPECT_EQ("value2", kv_pairs[1].second);
}
TEST_F(SplitStringIntoKeyValuePairsTest, EmptyKeyWithKeyValueDelimiter) {
EXPECT_TRUE(SplitStringIntoKeyValuePairs(":value1,key2:value2",
':', // Key-value delimiter
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment