Commit de8bc401 authored by Misha Efimov's avatar Misha Efimov Committed by Commit Bot

[Cronet] Set "use_crash_key_stubs=true" in Cronet builds.

- Removes Cronet dependency on Breakpad.
- Applies to developer environment and public bots.
- Reduces Cronet binary size, especially on iOS.
- Official buildbots will be updated separately.

Bug: 811308
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I24fe9075a731a507ed8861e1f4811d4d463bb80d
Reviewed-on: https://chromium-review.googlesource.com/964596
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544211}
parent 4c0b45ba
...@@ -133,6 +133,7 @@ def main(): ...@@ -133,6 +133,7 @@ def main():
'use_platform_icu_alternatives=true '+ \ 'use_platform_icu_alternatives=true '+ \
'enable_reporting=false '+ \ 'enable_reporting=false '+ \
'is_component_build=false ' + \ 'is_component_build=false ' + \
'use_crash_key_stubs=true ' + \
'ignore_elf32_limitations=true use_partition_alloc=false ' + \ 'ignore_elf32_limitations=true use_partition_alloc=false ' + \
'include_transport_security_state_preload_list=false ' 'include_transport_security_state_preload_list=false '
......
...@@ -98,6 +98,7 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''): ...@@ -98,6 +98,7 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):
build_dir = os.path.join("out", target_dir) build_dir = os.path.join("out", target_dir)
gn_args = 'target_os="ios" enable_websockets=false ' \ gn_args = 'target_os="ios" enable_websockets=false ' \
'is_cronet_build=true is_component_build=false ' \ 'is_cronet_build=true is_component_build=false ' \
'use_crash_key_stubs=true ' \
'disable_file_support=true disable_ftp_support=true ' \ 'disable_file_support=true disable_ftp_support=true ' \
'include_transport_security_state_preload_list=false ' \ 'include_transport_security_state_preload_list=false ' \
'ios_deployment_target="9.0" ' \ 'ios_deployment_target="9.0" ' \
......
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
"include_transport_security_state_preload_list=false", "include_transport_security_state_preload_list=false",
"ios_deployment_target=\"9.0\"", "ios_deployment_target=\"9.0\"",
"is_component_build=false", "is_component_build=false",
"use_crash_key_stubs=true",
"is_cronet_build=true", "is_cronet_build=true",
"is_debug=true", "is_debug=true",
"target_cpu=\"x64\"", "target_cpu=\"x64\"",
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
"goma_dir=\"$(goma_dir)\"", "goma_dir=\"$(goma_dir)\"",
"ios_deployment_target=\"9.0\"", "ios_deployment_target=\"9.0\"",
"is_component_build=false", "is_component_build=false",
"use_crash_key_stubs=true",
"is_cronet_build=true", "is_cronet_build=true",
"is_debug=true", "is_debug=true",
"target_cpu=\"x64\"", "target_cpu=\"x64\"",
......
...@@ -1881,6 +1881,7 @@ ...@@ -1881,6 +1881,7 @@
'enable_websockets=false use_platform_icu_alternatives=true ' 'enable_websockets=false use_platform_icu_alternatives=true '
'use_partition_alloc=false enable_reporting=false ' 'use_partition_alloc=false enable_reporting=false '
'include_transport_security_state_preload_list=false ' 'include_transport_security_state_preload_list=false '
'use_crash_key_stubs=true '
'clang_use_default_sample_profile=false'), 'clang_use_default_sample_profile=false'),
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment