Commit deb5943b authored by Maks Orlovich's avatar Maks Orlovich Committed by Commit Bot

SimpleCache: re-enable some tests on Windows.

They were disabled when Windows was not supported by the backend at all,
but now it is used for things like CacheStorage on the platform,
and there is support for renames of open files.

Change-Id: I69d353041a6920cfd6ec7d312026a3cc650ec3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1387685
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618324}
parent 8a716418
......@@ -41,11 +41,6 @@ using disk_cache::SimpleIndex;
namespace disk_cache {
// The Simple Cache backend requires a few guarantees from the filesystem like
// atomic renaming of recently open files. Those guarantees are not provided in
// general on Windows.
#if defined(OS_POSIX)
namespace {
uint32_t RoundSize(uint32_t in) {
......@@ -500,6 +495,4 @@ TEST_F(SimpleIndexFileTest, OverwritesStaleTempFile) {
EXPECT_TRUE(base::PathExists(simple_index_file.GetIndexFilePath()));
}
#endif // defined(OS_POSIX)
} // namespace disk_cache
......@@ -17,10 +17,6 @@
#include "net/disk_cache/simple/simple_entry_format_history.h"
#include "testing/gtest/include/gtest/gtest.h"
// The migration process relies on ability to rename newly created files, which
// could be problematic on Windows XP.
#if defined(OS_POSIX)
namespace {
// Same as |disk_cache::kSimpleInitialMagicNumber|.
......@@ -160,5 +156,3 @@ TEST(SimpleVersionUpgradeTest, UpgradeV5V6IndexMustDisappear) {
}
} // namespace
#endif // defined(OS_POSIX)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment