Commit dec91801 authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

Remove obsolete TODO in searchbox.cc

While we're here, also get rid of some "default:" cases in switches.

Bug: 468320
Change-Id: I8695af13f946c1f374bdf0402f93ec9dd491977f
Reviewed-on: https://chromium-review.googlesource.com/1215762Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589942}
parent 0962c66c
......@@ -56,9 +56,10 @@ const char* GetIconTypeUrlHost(SearchBox::ImageSourceType type) {
return "favicon";
case SearchBox::THUMB:
return "thumb";
default:
NOTREACHED();
case SearchBox::NONE:
break;
}
NOTREACHED();
return nullptr;
}
......@@ -66,7 +67,6 @@ const char* GetIconTypeUrlHost(SearchBox::ImageSourceType type) {
// depending on |type| of image URL. Returns -1 if parse fails.
int GetImagePathStartOfPageURL(SearchBox::ImageSourceType type,
const std::string& path) {
// TODO(huangs): Refactor this: http://crbug.com/468320.
switch (type) {
case SearchBox::FAVICON: {
chrome::ParsedFaviconPath parsed;
......@@ -75,11 +75,10 @@ int GetImagePathStartOfPageURL(SearchBox::ImageSourceType type,
case SearchBox::THUMB: {
return 0;
}
default: {
NOTREACHED();
case SearchBox::NONE:
break;
}
}
NOTREACHED();
return -1;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment