[iOS] Don't store SectionInfo int NTP "More" button

This CL makes sure that the SectionInfo variable isn't store in the
"more" callback on the NTP. This is because the SectionInfo can be
recreated for example when disabling/enabling the content suggestions.

Bug: 1023793, 1024172
Change-Id: I8edb799baedb3d1dd811a57db77d07298d97533e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913257Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715251}

ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

@@ -583,18 +583,24 @@ addSuggestionsToModel:(NSArray<CSCollectionViewItem*>*)suggestions
 - (void)addFooterIfNeeded:(ContentSuggestionsSectionInformation*)sectionInfo {
   NSInteger sectionIdentifier = SectionIdentifierForInfo(sectionInfo);
 
+  NSString* footerTitle = sectionInfo.footerTitle;
+
   __weak ContentSuggestionsCollectionUpdater* weakSelf = self;
-  if (sectionInfo.footerTitle &&
-      ![self.collectionViewController.collectionViewModel
-          footerForSectionWithIdentifier:sectionIdentifier]) {
+  if (footerTitle && ![self.collectionViewController.collectionViewModel
+                         footerForSectionWithIdentifier:sectionIdentifier]) {
     ContentSuggestionsFooterItem* footer = [[ContentSuggestionsFooterItem alloc]
         initWithType:ItemTypeFooter
                title:sectionInfo.footerTitle
             callback:^(ContentSuggestionsFooterItem* item,
                        ContentSuggestionsFooterCell* cell) {
-              [weakSelf runAdditionalActionForSection:sectionInfo
-                                             withItem:item
-                                                 cell:cell];
+              __typeof(self) strongSelf = weakSelf;
+              ContentSuggestionsSectionInformation* strongSectionInfo =
+                  strongSelf
+                      .sectionInfoBySectionIdentifier[@(sectionIdentifier)];
+              DCHECK([footerTitle isEqual:strongSectionInfo.footerTitle]);
+              [strongSelf runAdditionalActionForSection:strongSectionInfo
+                                               withItem:item
+                                                   cell:cell];
             }];
 
     [self.collectionViewController.collectionViewModel