Revert "Call PaintLayer::UpdateLayerPositionsAfterLayout only from layout roots."
This reverts commit b0caaa35. Reason for revert: Suspect introduces flake (https://crbug.com/990225). LayoutSubtreeRootList::RandomRoot is crashing in about 50% of builds since this landed. Original change's description: > Call PaintLayer::UpdateLayerPositionsAfterLayout only from layout roots. > > Previously, it always called it from the LayoutView, regardless of what > layout changed. > > This will be more efficient in typical cases of non-root layouts. It > may be more inefficient in the following cases > a. Two layout roots are present, of which one is an ancestor of the other > (in this case, the new code will update the overlapping layout tree > portions twice). > b. Cases when LocalFrameview::UpdateLayout recurses, due to NeedsLayout > being true after the first one. > > If we consider these cases sufficiently rare, then this CL is ok as-is. > Handling (a) and (b) is possible but is harder to implement. > > Bug: 462719,970224 > Change-Id: Ie65dc73a70bb9362dfa20ff9ad4070e3945d3c56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728717 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683409} TBR=szager@chromium.org,chrishtr@chromium.org,eae@chromium.org Change-Id: I50a9d9861dae814d0c564e072df8a1c66a9b5898 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 462719, 970224, 990225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732809Reviewed-by:Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683469}
Showing
Please register or sign in to comment