Commit deeffeaf authored by Jonah Ryan-Davis's avatar Jonah Ryan-Davis Committed by Commit Bot

Test validating and passthrough versions of GPU tests on Mac

Mac DefaultPassthroughCommandDecoder is ready to be finched, so we
need test coverage for both command decoders. This CL adds passthrough
test coverage for context_lost, screenshot_sync, pixel_skia_gold,
and maps_pixel_test.

Bug: chromium:982292
Bug: chromium:1090853
Change-Id: Ib264875dc22cf15efe3a9395424da8e30554a8a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246630
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: default avatarYuly Novikov <ynovikov@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779892}
parent ccb60913
This diff is collapsed.
This diff is collapsed.
......@@ -990,6 +990,11 @@
},
'context_lost_passthrough_tests': {
'modifications': {
'Mac FYI GPU ASAN Release': {
'args': [
'--is-asan',
]
},
'Win10 x64 Debug (NVIDIA)': {
'args': [
# TODO(https://crbug.com/1007013): Remove this flag when it's no
......@@ -1084,6 +1089,63 @@
'Linux Chromium OS ASan LSan Tests (1)', # https://crbug.com/831667
],
},
'gl_tests_passthrough': {
'remove_from': [
'CFI Linux ToT',
# Can't run on MSAN because gl_tests uses the hardware driver,
# which isn't instrumented.
'Linux MSan Tests',
],
'modifications': {
# TODO(kbr): figure out a better way to specify blocks of
# arguments like this for tests on multiple machines.
'Linux ASan LSan Tests (1)': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'chromium.tests.gpu.template',
},
],
},
},
'Linux CFI': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'chromium.tests.gpu.template',
},
],
},
},
'Linux TSan Tests': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'chromium.tests.gpu.template',
},
],
},
},
},
},
'gl_tests_validating': {
'remove_from': [
'CFI Linux ToT',
......@@ -1351,6 +1413,11 @@
'--git-revision': '${got_cr_revision}',
},
},
'Mac V8 FYI Release (Intel)': {
'args': {
'--git-revision': '${got_cr_revision}',
},
},
'Win V8 FYI Release (NVIDIA)': {
'args': {
'--git-revision': '${got_cr_revision}',
......@@ -1988,6 +2055,11 @@
'--git-revision': '${got_cr_revision}',
},
},
'Mac V8 FYI Release (Intel)': {
'args': {
'--git-revision': '${got_cr_revision}',
},
},
'Win V8 FYI Release (NVIDIA)': {
'args': {
'--git-revision': '${got_cr_revision}',
......
......@@ -4673,7 +4673,6 @@
'gpu_angle_mac_gtests': [
'gpu_angle_end2end_gtests',
'gpu_angle_unit_gtests',
'gpu_common_gtests_validating',
'gpu_fyi_and_optional_non_linux_gtests',
'gpu_gles2_conform_gtests',
],
......@@ -4910,6 +4909,7 @@
'gpu_fyi_mac_release_telemetry_tests': [
'gpu_common_and_optional_telemetry_tests',
'gpu_passthrough_telemetry_tests',
'gpu_validating_telemetry_tests',
'gpu_webgl2_conformance_gl_passthrough_telemetry_tests',
'gpu_webgl2_conformance_validating_telemetry_tests',
......@@ -4926,6 +4926,7 @@
'gpu_fyi_optional_mac_telemetry_tests': [
'gpu_common_and_optional_telemetry_tests',
'gpu_passthrough_telemetry_tests',
'gpu_webgl2_conformance_validating_telemetry_tests',
'gpu_webgl_conformance_gl_passthrough_telemetry_tests',
'gpu_webgl_conformance_swangle_passthrough_telemetry_tests',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment