Commit df0359ea authored by Alex Rudenko's avatar Alex Rudenko Committed by Commit Bot

Reland "Enable test for persistent overlays"

This is a reland of b37c27dc with an
addition of requesting an animation frame to avoid flakiness.

Original change's description:
> Enable test for persistent overlays
>
> The test has been implemented in [1] and now, when DevTools rolled,
> it can be enabled.
>
> [1]: crrev.com/c/2400478
>
> Bug: 1109224
> Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811260}

Bug: 1109224
Change-Id: I5f40fe8855d69870fab7253f9315d5ffde004dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437371Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811611}
parent 41da4b98
...@@ -1822,9 +1822,6 @@ crbug.com/1051044 external/wpt/css/filter-effects/effect-reference-feimage-003.h ...@@ -1822,9 +1822,6 @@ crbug.com/1051044 external/wpt/css/filter-effects/effect-reference-feimage-003.h
crbug.com/524160 [ Debug ] http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html [ Timeout ] crbug.com/524160 [ Debug ] http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-default-buffers.html [ Timeout ]
# Awaiting DevTools roll.
crbug.com/1109224 inspector-protocol/overlay/overlay-persistent-overlays.js [ Pass Failure ]
# On these platforms (all but Android) media tests don't currently use gpu-accelerated (proprietary) codecs, so no # On these platforms (all but Android) media tests don't currently use gpu-accelerated (proprietary) codecs, so no
# benefit to running them again with gpu acceleration enabled. # benefit to running them again with gpu acceleration enabled.
crbug.com/555703 [ Linux ] virtual/media-gpu-accelerated/* [ Skip ] crbug.com/555703 [ Linux ] virtual/media-gpu-accelerated/* [ Skip ]
......
...@@ -42,6 +42,11 @@ ...@@ -42,6 +42,11 @@
}] }]
}); });
// Wait for overlay rendering to finish by requesting an animation frame.
await session.evaluate(() => {
return new Promise(resolve => requestAnimationFrame(resolve));
});
testRunner.log('Expected 3 track size labels; actual: ' + await getTrackSizeLabels()); testRunner.log('Expected 3 track size labels; actual: ' + await getTrackSizeLabels());
testRunner.completeTest(); testRunner.completeTest();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment