Commit df03a773 authored by achuith@chromium.org's avatar achuith@chromium.org

Replace NewRunnableMethod with Callback in DownloadItem.

BUG=chromium-os:22024
TEST=compiles, tests pass.
Review URL: http://codereview.chromium.org/8413016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107786 0039d316-1c4b-4281-b951-d872f2087c98
parent 2a0814f0
...@@ -4,6 +4,9 @@ ...@@ -4,6 +4,9 @@
#include "content/browser/download/download_item.h" #include "content/browser/download/download_item.h"
#include <vector>
#include "base/bind.h"
#include "base/basictypes.h" #include "base/basictypes.h"
#include "base/file_util.h" #include "base/file_util.h"
#include "base/format_macros.h" #include "base/format_macros.h"
...@@ -506,7 +509,7 @@ void DownloadItem::Delete(DeleteReason reason) { ...@@ -506,7 +509,7 @@ void DownloadItem::Delete(DeleteReason reason) {
} }
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
NewRunnableFunction(&DeleteDownloadedFile, full_path_)); base::Bind(&DeleteDownloadedFile, full_path_));
Remove(); Remove();
// We have now been deleted. // We have now been deleted.
} }
...@@ -595,16 +598,17 @@ void DownloadItem::OnDownloadCompleting(DownloadFileManager* file_manager) { ...@@ -595,16 +598,17 @@ void DownloadItem::OnDownloadCompleting(DownloadFileManager* file_manager) {
if (NeedsRename()) { if (NeedsRename()) {
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
NewRunnableMethod(file_manager, base::Bind(&DownloadFileManager::RenameCompletingDownloadFile,
&DownloadFileManager::RenameCompletingDownloadFile, global_id(), file_manager, global_id(),
GetTargetFilePath(), safety_state() == SAFE)); GetTargetFilePath(), safety_state() == SAFE));
return; return;
} }
Completed(); Completed();
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, NewRunnableMethod( BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
file_manager, &DownloadFileManager::CompleteDownload, global_id())); base::Bind(&DownloadFileManager::CompleteDownload,
file_manager, global_id()));
} }
void DownloadItem::OnDownloadRenamedToFinalName(const FilePath& full_path) { void DownloadItem::OnDownloadRenamedToFinalName(const FilePath& full_path) {
...@@ -724,10 +728,9 @@ void DownloadItem::OffThreadCancel(DownloadFileManager* file_manager) { ...@@ -724,10 +728,9 @@ void DownloadItem::OffThreadCancel(DownloadFileManager* file_manager) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
request_handle_.CancelRequest(); request_handle_.CancelRequest();
BrowserThread::PostTask( BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
BrowserThread::FILE, FROM_HERE, base::Bind(&DownloadFileManager::CancelDownload,
NewRunnableMethod( file_manager, global_id()));
file_manager, &DownloadFileManager::CancelDownload, global_id()));
} }
void DownloadItem::Init(bool active) { void DownloadItem::Init(bool active) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment