Commit df156a53 authored by Jaeyong Bae's avatar Jaeyong Bae Committed by Commit Bot

[Passwords] Add PasswordManager.AccessPasswordInSettings

This adds histograms to count how passwords are shown in settings.
Having PasswordManager.AccessPasswordInSettings on Android
in addition to the current histograms is beneficial.

Bug: 885245
Change-Id: Ia231316ac476135c6eb4dcecc3f070f7a0e585c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966961Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#726251}
parent 6d72de06
......@@ -79,6 +79,11 @@ public class PasswordEntryViewer
private static final int PASSWORD_ACTION_HIDDEN = 2;
private static final int PASSWORD_ACTION_BOUNDARY = 3;
// Metrics: "PasswordManager.AccessPasswordInSettings"
private static final int ACCESS_PASSWORD_VIEWED = 0;
private static final int ACCESS_PASSWORD_COPIED = 1;
private static final int ACCESS_PASSWORD_COUNT = 2;
// ID of this name/password or exception.
private int mID;
......@@ -355,6 +360,9 @@ public class PasswordEntryViewer
RecordHistogram.recordEnumeratedHistogram(
"PasswordManager.Android.PasswordCredentialEntry.Password",
PASSWORD_ACTION_DISPLAYED, PASSWORD_ACTION_BOUNDARY);
RecordHistogram.recordEnumeratedHistogram("PasswordManager.AccessPasswordInSettings",
ACCESS_PASSWORD_VIEWED, ACCESS_PASSWORD_COUNT);
}
private void hidePassword() {
......@@ -380,6 +388,9 @@ public class PasswordEntryViewer
RecordHistogram.recordEnumeratedHistogram(
"PasswordManager.Android.PasswordCredentialEntry.Password", PASSWORD_ACTION_COPIED,
PASSWORD_ACTION_BOUNDARY);
RecordHistogram.recordEnumeratedHistogram("PasswordManager.AccessPasswordInSettings",
ACCESS_PASSWORD_COPIED, ACCESS_PASSWORD_COUNT);
}
private void hookupPasswordButtons() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment