Commit df18b96b authored by Stephen White's avatar Stephen White Committed by Commit Bot

Adjust the edge-AA tessellator maximum verb count.

Increasing the verb count from 10 to 100 in Skia's edge-AA tessellating
path renderer improves performance on many tests, including
Animometer's Canvas Stroke Paths and the bugs listed below.

Bug: 805031, 223694, 715116
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I57d775ddce3200e5f54bae448de9fd2dffe30e72
Reviewed-on: https://chromium-review.googlesource.com/1099564Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Reviewed-by: default avatarJustin Novosad <junov@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568155}
parent 19de023d
...@@ -16,6 +16,10 @@ class PixelExpectations(GpuTestExpectations): ...@@ -16,6 +16,10 @@ class PixelExpectations(GpuTestExpectations):
self.Flaky('Pixel_GpuRasterization_BlueBox', self.Flaky('Pixel_GpuRasterization_BlueBox',
['win', ('amd', 0x6613)], bug=653538) ['win', ('amd', 0x6613)], bug=653538)
# TODO(senorblanco) generate new reference images after Edge-AA tess change.
self.Fail('Pixel_OffscreenCanvasAccelerated2D')
self.Fail('Pixel_OffscreenCanvasAccelerated2DWorker')
# Software compositing is not supported on Android; so we skip these tests # Software compositing is not supported on Android; so we skip these tests
# that disables gpu compositing on Android platforms. # that disables gpu compositing on Android platforms.
self.Skip('Pixel_OffscreenCanvasUnaccelerated2D', ['android']) self.Skip('Pixel_OffscreenCanvasUnaccelerated2D', ['android'])
......
...@@ -468,14 +468,14 @@ def ExperimentalCanvasFeaturesPages(base_name): ...@@ -468,14 +468,14 @@ def ExperimentalCanvasFeaturesPages(base_name):
'pixel_offscreenCanvas_2d_commit_main.html', 'pixel_offscreenCanvas_2d_commit_main.html',
base_name + '_OffscreenCanvasAccelerated2D', base_name + '_OffscreenCanvasAccelerated2D',
test_rect=[0, 0, 360, 200], test_rect=[0, 0, 360, 200],
revision=10, revision=11,
browser_args=browser_args), browser_args=browser_args),
PixelTestPage( PixelTestPage(
'pixel_offscreenCanvas_2d_commit_worker.html', 'pixel_offscreenCanvas_2d_commit_worker.html',
base_name + '_OffscreenCanvasAccelerated2DWorker', base_name + '_OffscreenCanvasAccelerated2DWorker',
test_rect=[0, 0, 360, 200], test_rect=[0, 0, 360, 200],
revision=10, revision=11,
browser_args=browser_args), browser_args=browser_args),
PixelTestPage( PixelTestPage(
......
...@@ -225,7 +225,7 @@ SK_API void SkDebugf_FileLine(const char* file, int line, bool fatal, ...@@ -225,7 +225,7 @@ SK_API void SkDebugf_FileLine(const char* file, int line, bool fatal,
#endif #endif
// Max. verb count for paths rendered by the edge-AA tessellating path renderer. // Max. verb count for paths rendered by the edge-AA tessellating path renderer.
#define GR_AA_TESSELLATOR_MAX_VERB_COUNT 10 #define GR_AA_TESSELLATOR_MAX_VERB_COUNT 100
// Remove this and rebaseline affected layout tests. // Remove this and rebaseline affected layout tests.
#define SK_DONT_DROP_UNNECESSARY_AA_IN_TEXTURE_OP #define SK_DONT_DROP_UNNECESSARY_AA_IN_TEXTURE_OP
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment