Commit df21c223 authored by Michael Warres's avatar Michael Warres Committed by Commit Bot

Fix ios-device-xcode-clang compilation error introduced by...

Fix ios-device-xcode-clang compilation error introduced by https://chromium-review.googlesource.com/c/chromium/src/+/956843

The compilation error appears to be due to clang bug
https://bugs.llvm.org/show_bug.cgi?id=21629 , which has been fixed recently,
but apparently has not made it into the clang used by ios-device-xcode-clang.

R=rch@chromium.org

Bug: 820529
Change-Id: Iaac1d28f2209502c4ce4683b3f590d9140fe3141
Reviewed-on: https://chromium-review.googlesource.com/956299Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Commit-Queue: Michael Warres <mpw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542244}
parent 948041c1
...@@ -832,9 +832,11 @@ TEST_F(QuicIetfFramerTest, PaddingSandwich) { ...@@ -832,9 +832,11 @@ TEST_F(QuicIetfFramerTest, PaddingSandwich) {
} }
TEST_F(QuicIetfFramerTest, PathChallengeFrame) { TEST_F(QuicIetfFramerTest, PathChallengeFrame) {
QuicPathFrameBuffer buffer0 = {0, 0, 0, 0, 0, 0, 0, 0}; // Double-braces needed on some platforms due to
QuicPathFrameBuffer buffer1 = {0x80, 0x91, 0xa2, 0xb3, // https://bugs.llvm.org/show_bug.cgi?id=21629
0xc4, 0xd5, 0xe5, 0xf7}; QuicPathFrameBuffer buffer0 = {{0, 0, 0, 0, 0, 0, 0, 0}};
QuicPathFrameBuffer buffer1 = {
{0x80, 0x91, 0xa2, 0xb3, 0xc4, 0xd5, 0xe5, 0xf7}};
char packet_buffer[kNormalPacketBufferSize]; char packet_buffer[kNormalPacketBufferSize];
EXPECT_TRUE( EXPECT_TRUE(
TryPathChallengeFrame(packet_buffer, sizeof(packet_buffer), buffer0)); TryPathChallengeFrame(packet_buffer, sizeof(packet_buffer), buffer0));
...@@ -843,9 +845,11 @@ TEST_F(QuicIetfFramerTest, PathChallengeFrame) { ...@@ -843,9 +845,11 @@ TEST_F(QuicIetfFramerTest, PathChallengeFrame) {
} }
TEST_F(QuicIetfFramerTest, PathResponseFrame) { TEST_F(QuicIetfFramerTest, PathResponseFrame) {
QuicPathFrameBuffer buffer0 = {0, 0, 0, 0, 0, 0, 0, 0}; // Double-braces needed on some platforms due to
QuicPathFrameBuffer buffer1 = {0x80, 0x91, 0xa2, 0xb3, // https://bugs.llvm.org/show_bug.cgi?id=21629
0xc4, 0xd5, 0xe5, 0xf7}; QuicPathFrameBuffer buffer0 = {{0, 0, 0, 0, 0, 0, 0, 0}};
QuicPathFrameBuffer buffer1 = {
{0x80, 0x91, 0xa2, 0xb3, 0xc4, 0xd5, 0xe5, 0xf7}};
char packet_buffer[kNormalPacketBufferSize]; char packet_buffer[kNormalPacketBufferSize];
EXPECT_TRUE( EXPECT_TRUE(
TryPathResponseFrame(packet_buffer, sizeof(packet_buffer), buffer0)); TryPathResponseFrame(packet_buffer, sizeof(packet_buffer), buffer0));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment