Commit df251f06 authored by Samuel Attard's avatar Samuel Attard Committed by Commit Bot

add rpath to chromedriver when ffmpeg is a component_build

When chromedriver is built with a dynamically linked ffmpeg on macOS
we need to set the rpath so that ffmpeg.dylib is loaded correctly.

Change-Id: I204810ac8610375aa8b0a2e7fae78464c1a3371e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033343Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737510}
parent 069a3c6e
......@@ -6,6 +6,7 @@ import("//build/config/python.gni")
import("//build/config/ui.gni")
import("//build/util/lastchange.gni")
import("//testing/test.gni")
import("//third_party/ffmpeg/ffmpeg_options.gni")
action("embed_js_in_cpp") {
script = "embed_js_in_cpp.py"
......@@ -330,6 +331,13 @@ executable("chromedriver") {
"//net/traffic_annotation:test_support",
"//services/network/public/mojom",
]
if (is_mac && is_component_ffmpeg) {
ldflags = [
"-rpath",
"@executable_path/.",
]
}
}
python_library("chromedriver_py_tests") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment