[directorytree] Add files-ng generic provided icons if needed
Every volume type in FilesApp has volumeMetadata from chrome.FMP, that contains an iconSet property: it is empty (contains no icons) for most volume types. Somes volumes like AndroidAppItem, PROVIDED, and DOCUMENT_PROVIDER can (and usually do) provide icons in the iconSet property. If they don't, FilesApp draws nothing in their .tree-row .item-icon element today. AndroidAppItem volumes can provide icons: in the files-ng case, draw a generic provided icon if their iconSet has no icons. VolumeItem PROVIDED and DOCUMENT_PROVIDER can provide icons, but there is no reliable way to detect/fix their missing icons today since other volume types use VolumeItem too. If they don't provide icons, FilesApp files-ng will now draw a gray box in their .item-icon, a visual change in behavior compared to normal FilesApp. Bug: 992819 Change-Id: I6d2ec07ef91fd3acd8edff8bc5053eab4450680c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945958Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721279}
Showing
Please register or sign in to comment