Commit df34ae7b authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/ui/extensions.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=benwells@chromium.org

Bug: 925652
Change-Id: Ibebae3e41aeb0549156b1aace0aa7197e821fe62
Reviewed-on: https://chromium-review.googlesource.com/c/1438317
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626924}
parent 9312348e
...@@ -407,9 +407,9 @@ TEST_P(ExtensionActionViewControllerGrayscaleTest, ...@@ -407,9 +407,9 @@ TEST_P(ExtensionActionViewControllerGrayscaleTest,
RunGrayscaleTest(PermissionType::kScriptableHost); RunGrayscaleTest(PermissionType::kScriptableHost);
} }
INSTANTIATE_TEST_CASE_P(, INSTANTIATE_TEST_SUITE_P(,
ExtensionActionViewControllerGrayscaleTest, ExtensionActionViewControllerGrayscaleTest,
testing::Values(false, true)); testing::Values(false, true));
TEST_P(ToolbarActionsBarUnitTest, RuntimeHostsTooltip) { TEST_P(ToolbarActionsBarUnitTest, RuntimeHostsTooltip) {
base::test::ScopedFeatureList feature_list; base::test::ScopedFeatureList feature_list;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment