Commit df61813a authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Remove a >6-year-old TODO that is long dead.

It refers to working around some bug that no longer seems to exist.

Bug: none
Change-Id: I040aad0433f620cf68aec3909379f61b53dccf27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100021
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: default avatarThomas Lukaszewicz <tluk@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749649}
parent f90c1176
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "ui/views/widget/native_widget_aura.h" #include "ui/views/widget/native_widget_aura.h"
#include <memory> #include <memory>
#include <utility>
#include "base/command_line.h" #include "base/command_line.h"
#include "base/macros.h" #include "base/macros.h"
...@@ -435,10 +436,6 @@ TEST_F(NativeWidgetAuraTest, DontCaptureOnGesture) { ...@@ -435,10 +436,6 @@ TEST_F(NativeWidgetAuraTest, DontCaptureOnGesture) {
EXPECT_TRUE(view->got_gesture_event()); EXPECT_TRUE(view->got_gesture_event());
EXPECT_FALSE(child->got_gesture_event()); EXPECT_FALSE(child->got_gesture_event());
view->clear_got_gesture_event(); view->clear_got_gesture_event();
// Work around for bug in NativeWidgetAura.
// TODO: fix bug and remove this.
widget->Close();
} }
// Verifies views with layers are targeted for events properly. // Verifies views with layers are targeted for events properly.
...@@ -496,10 +493,6 @@ TEST_F(NativeWidgetAuraTest, PreferViewLayersToChildWindows) { ...@@ -496,10 +493,6 @@ TEST_F(NativeWidgetAuraTest, PreferViewLayersToChildWindows) {
EXPECT_EQ( EXPECT_EQ(
child->GetNativeWindow(), child->GetNativeWindow(),
parent->GetNativeWindow()->GetEventHandlerForPoint(gfx::Point(20, 20))); parent->GetNativeWindow()->GetEventHandlerForPoint(gfx::Point(20, 20)));
// Work around for bug in NativeWidgetAura.
// TODO: fix bug and remove this.
parent->Close();
} }
// Verifies views with layers are targeted for events properly. // Verifies views with layers are targeted for events properly.
......
...@@ -118,10 +118,6 @@ TEST_F(WindowReordererTest, Basic) { ...@@ -118,10 +118,6 @@ TEST_F(WindowReordererTest, Basic) {
EXPECT_EQ("w1 w2", ChildWindowNamesAsString(*parent_window)); EXPECT_EQ("w1 w2", ChildWindowNamesAsString(*parent_window));
EXPECT_EQ("w1 v w2", EXPECT_EQ("w1 v w2",
ui::test::ChildLayerNamesAsString(*parent_window->layer())); ui::test::ChildLayerNamesAsString(*parent_window->layer()));
// Work around for bug in NativeWidgetAura.
// TODO: fix bug and remove this.
parent->Close();
} }
// Test that different orderings of: // Test that different orderings of:
...@@ -178,10 +174,6 @@ TEST_F(WindowReordererTest, Association) { ...@@ -178,10 +174,6 @@ TEST_F(WindowReordererTest, Association) {
EXPECT_EQ("w2 w1", ChildWindowNamesAsString(*parent_window)); EXPECT_EQ("w2 w1", ChildWindowNamesAsString(*parent_window));
EXPECT_EQ("w2 w1", EXPECT_EQ("w2 w1",
ui::test::ChildLayerNamesAsString(*parent_window->layer())); ui::test::ChildLayerNamesAsString(*parent_window->layer()));
// Work around for bug in NativeWidgetAura.
// TODO: fix bug and remove this.
parent->Close();
} }
// It is possible to associate a window to a view which has a parent layer // It is possible to associate a window to a view which has a parent layer
...@@ -250,10 +242,6 @@ TEST_F(WindowReordererTest, HostViewParentHasLayer) { ...@@ -250,10 +242,6 @@ TEST_F(WindowReordererTest, HostViewParentHasLayer) {
EXPECT_EQ("w", ChildWindowNamesAsString(*parent_window)); EXPECT_EQ("w", ChildWindowNamesAsString(*parent_window));
EXPECT_EQ("v1 v2 w", EXPECT_EQ("v1 v2 w",
ui::test::ChildLayerNamesAsString(*parent_window->layer())); ui::test::ChildLayerNamesAsString(*parent_window->layer()));
// Work around for bug in NativeWidgetAura.
// TODO: fix bug and remove this.
parent->Close();
} }
// Test that a layer added beneath a view is restacked correctly. // Test that a layer added beneath a view is restacked correctly.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment