Commit df7ae5db authored by gogerald's avatar gogerald Committed by Chromium LUCI CQ

Add metrics for native UIs

Bug: 1168574
Change-Id: I41f45073df9b7a8249d9c5b529439d718a32675a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640633
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
Reviewed-by: default avatarDan H <harringtond@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845298}
parent 07eb01fe
...@@ -75,10 +75,18 @@ enum class FeedUserActionType { ...@@ -75,10 +75,18 @@ enum class FeedUserActionType {
kClosedDialog = 21, kClosedDialog = 21,
// User action caused a snackbar to be shown. User action not reported here. // User action caused a snackbar to be shown. User action not reported here.
kShowSnackbar = 22, kShowSnackbar = 22,
// User opened the native back of card menu. // User opened back of card menu in the native action sheet.
kOpenedNativeContextMenu = 23, kOpenedNativeActionSheet = 23,
// User opened back of card menu in the native context menu.
kOpenedNativeContextMenu = 24,
// User closed back of card menu in the native context menu.
kClosedNativeContextMenu = 25,
// User opened back of card menu in the native pull-down menu.
kOpenedNativePulldownMenu = 26,
// User closed back of card menu in the native pull-down menu.
kClosedNativePulldownMenu = 27,
// Highest enumerator. Recommended by Histogram metrics best practices. // Highest enumerator. Recommended by Histogram metrics best practices.
kMaxValue = kOpenedNativeContextMenu, kMaxValue = kClosedNativePulldownMenu,
}; };
} // namespace feed } // namespace feed
......
...@@ -106,6 +106,12 @@ ...@@ -106,6 +106,12 @@
(NSTimeInterval)durationInSeconds (NSTimeInterval)durationInSeconds
success:(BOOL)success; success:(BOOL)success;
// Records the native context menu visibility change.
- (void)recordNativeContextMenuVisibilityChanged:(BOOL)shown;
// Records the native pull-down menu visibility change.
- (void)recordNativePulldownMenuVisibilityChanged:(BOOL)shown;
@end @end
#endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_DISCOVER_FEED_METRICS_RECORDER_H_ #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_DISCOVER_FEED_METRICS_RECORDER_H_
...@@ -87,8 +87,16 @@ const char kDiscoverFeedUserActionHideStory[] = ...@@ -87,8 +87,16 @@ const char kDiscoverFeedUserActionHideStory[] =
"ContentSuggestions.Feed.CardAction.HideStory"; "ContentSuggestions.Feed.CardAction.HideStory";
const char kDiscoverFeedUserActionCloseContextMenu[] = const char kDiscoverFeedUserActionCloseContextMenu[] =
"ContentSuggestions.Feed.CardAction.ClosedContextMenu"; "ContentSuggestions.Feed.CardAction.ClosedContextMenu";
const char kDiscoverFeedUserActionNativeActionSheetOpened[] =
"ContentSuggestions.Feed.CardAction.OpenNativeActionSheet";
const char kDiscoverFeedUserActionNativeContextMenuOpened[] = const char kDiscoverFeedUserActionNativeContextMenuOpened[] =
"ContentSuggestions.Feed.CardAction.NativeContextMenu"; "ContentSuggestions.Feed.CardAction.OpenNativeContextMenu";
const char kDiscoverFeedUserActionNativeContextMenuClosed[] =
"ContentSuggestions.Feed.CardAction.CloseNativeContextMenu";
const char kDiscoverFeedUserActionNativePulldownMenuOpened[] =
"ContentSuggestions.Feed.CardAction.OpenNativePulldownMenu";
const char kDiscoverFeedUserActionNativePulldownMenuClosed[] =
"ContentSuggestions.Feed.CardAction.CloseNativePulldownMenu";
const char kDiscoverFeedUserActionReportContentOpened[] = const char kDiscoverFeedUserActionReportContentOpened[] =
"ContentSuggestions.Feed.CardAction.ReportContent"; "ContentSuggestions.Feed.CardAction.ReportContent";
const char kDiscoverFeedUserActionReportContentClosed[] = const char kDiscoverFeedUserActionReportContentClosed[] =
...@@ -276,9 +284,9 @@ const int kMinutesBetweenSessions = 5; ...@@ -276,9 +284,9 @@ const int kMinutesBetweenSessions = 5;
- (void)recordOpenNativeBackOfCardMenu { - (void)recordOpenNativeBackOfCardMenu {
[self recordDiscoverFeedUserActionHistogram:FeedUserActionType:: [self recordDiscoverFeedUserActionHistogram:FeedUserActionType::
kOpenedNativeContextMenu]; kOpenedNativeActionSheet];
base::RecordAction( base::RecordAction(
base::UserMetricsAction(kDiscoverFeedUserActionNativeContextMenuOpened)); base::UserMetricsAction(kDiscoverFeedUserActionNativeActionSheetOpened));
} }
- (void)recordShowDialog { - (void)recordShowDialog {
...@@ -365,6 +373,34 @@ const int kMinutesBetweenSessions = 5; ...@@ -365,6 +373,34 @@ const int kMinutesBetweenSessions = 5;
[self recordNetworkRequestDurationInSeconds:durationInSeconds]; [self recordNetworkRequestDurationInSeconds:durationInSeconds];
} }
- (void)recordNativeContextMenuVisibilityChanged:(BOOL)shown {
if (shown) {
[self recordDiscoverFeedUserActionHistogram:FeedUserActionType::
kOpenedNativeContextMenu];
base::RecordAction(base::UserMetricsAction(
kDiscoverFeedUserActionNativeContextMenuOpened));
} else {
[self recordDiscoverFeedUserActionHistogram:FeedUserActionType::
kClosedNativeContextMenu];
base::RecordAction(base::UserMetricsAction(
kDiscoverFeedUserActionNativeContextMenuClosed));
}
}
- (void)recordNativePulldownMenuVisibilityChanged:(BOOL)shown {
if (shown) {
[self recordDiscoverFeedUserActionHistogram:FeedUserActionType::
kOpenedNativePulldownMenu];
base::RecordAction(base::UserMetricsAction(
kDiscoverFeedUserActionNativePulldownMenuOpened));
} else {
[self recordDiscoverFeedUserActionHistogram:FeedUserActionType::
kClosedNativePulldownMenu];
base::RecordAction(base::UserMetricsAction(
kDiscoverFeedUserActionNativePulldownMenuClosed));
}
}
#pragma mark - Private #pragma mark - Private
// Records histogram metrics for Discover feed user actions. // Records histogram metrics for Discover feed user actions.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment