Commit dfb2e49b authored by Shelley Vohr's avatar Shelley Vohr Committed by Commit Bot

Fix missing WeakPtr check in PreconnectManager

https://chromium-review.googlesource.com/c/chromium/src/+/2295780
added UKM around prefetch accuracy stats, which involved an added line
in PreconnectManager::TryToLaunchPreresolveJobs() that did not check
the WeakPtr before using it. This fixes that.

Change-Id: I3cdf84d0f84fb9cc59811817efb1bdd42d15cf38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309029Reviewed-by: default avatarSophie Chang <sophiechang@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790375}
parent 7c2685ca
...@@ -231,7 +231,8 @@ void PreconnectManager::TryToLaunchPreresolveJobs() { ...@@ -231,7 +231,8 @@ void PreconnectManager::TryToLaunchPreresolveJobs() {
weak_factory_.GetWeakPtr(), job_id)); weak_factory_.GetWeakPtr(), job_id));
if (info) { if (info) {
++info->inflight_count; ++info->inflight_count;
delegate_->PreconnectInitiated(info->url, job->url); if (delegate_)
delegate_->PreconnectInitiated(info->url, job->url);
} }
++inflight_preresolves_count_; ++inflight_preresolves_count_;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment