Avoid empty nearby URL list after onboarding by permitting unresolved URLs
We currently resolve nearby URLs twice, once before showing a "nearby web pages found" notification and once just before displaying the list of nearby URLs. If a URL was not resolvable for the notification we avoid re-resolving it for display. This prevents costly delays at display time as we are only requesting data expected to already be cached by the resolution service. During onboarding (ie, before the user has explicitly opted into the physical web feature) we still scan for nearby URLs but do not resolve them for privacy reasons. This causes all URLs to be considered "unresolvable" immediately after opting in as none have been sent to the resolution service yet. To fix, at display time allow ListUrlsActivity to receive the full list of nearby URLs (including unresolved) only if the resolved list is empty. BUG=529962 Review URL: https://codereview.chromium.org/1556453002 Cr-Commit-Position: refs/heads/master@{#367041}
Showing
Please register or sign in to comment