Commit dfcb9580 authored by W. James MacLean's avatar W. James MacLean Committed by Commit Bot

Remove BrowserPlugin Tooltip IPC.

This CL removes the tooltip IPC code from BrowserPlugin and
BrowserPluginGuest. This code is no longer in use since mouse events
are directly routed to the guest, and no longer go through the
embedder.

Bug: 533069
Change-Id: I916b534d86faf81d64f855368d055f8faccaf440
Reviewed-on: https://chromium-review.googlesource.com/895192Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533717}
parent 9350f6e6
......@@ -251,15 +251,6 @@ void BrowserPluginGuest::SetFocus(RenderWidgetHost* rwh,
SendTextInputTypeChangedToView(rwhv);
}
void BrowserPluginGuest::SetTooltipText(const base::string16& tooltip_text) {
if (tooltip_text == current_tooltip_text_)
return;
current_tooltip_text_ = tooltip_text;
SendMessageToEmbedder(std::make_unique<BrowserPluginMsg_SetTooltipText>(
browser_plugin_instance_id_, tooltip_text));
}
bool BrowserPluginGuest::LockMouse(bool allowed) {
if (!attached() || (mouse_locked_ == allowed))
return false;
......
......@@ -125,9 +125,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,
bool focused,
blink::WebFocusType focus_type);
// Sets the tooltip text.
void SetTooltipText(const base::string16& tooltip_text);
// Sets the lock state of the pointer. Returns true if |allowed| is true and
// the mouse has been successfully locked.
bool LockMouse(bool allowed);
......
......@@ -206,11 +206,6 @@ IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetMouseLock,
int /* browser_plugin_instance_id */,
bool /* enable */)
// Sends text to be displayed in tooltip.
IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetTooltipText,
int /* browser_plugin_instance_id */,
base::string16 /* tooltip_text */)
#if defined(USE_AURA)
// Sets the token that is used to embed the guest. |embed_token| is a token
// that was generated from the window server and is expected to be supplied to
......
......@@ -130,7 +130,6 @@ bool BrowserPlugin::OnMessageReceived(const IPC::Message& message) {
#if defined(USE_AURA)
IPC_MESSAGE_HANDLER(BrowserPluginMsg_SetMusEmbedToken, OnSetMusEmbedToken)
#endif
IPC_MESSAGE_HANDLER(BrowserPluginMsg_SetTooltipText, OnSetTooltipText)
IPC_MESSAGE_HANDLER(BrowserPluginMsg_ShouldAcceptTouchEvents,
OnShouldAcceptTouchEvents)
IPC_MESSAGE_HANDLER(BrowserPluginMsg_SetChildFrameSurface,
......@@ -361,12 +360,6 @@ void BrowserPlugin::OnSetMusEmbedToken(
}
#endif
void BrowserPlugin::OnSetTooltipText(int instance_id,
const base::string16& tooltip_text) {
// Show tooltip text by setting the BrowserPlugin's |title| attribute.
UpdateDOMAttribute("title", tooltip_text);
}
void BrowserPlugin::OnShouldAcceptTouchEvents(int browser_plugin_instance_id,
bool accept) {
if (Container()) {
......
......@@ -194,8 +194,6 @@ class CONTENT_EXPORT BrowserPlugin : public blink::WebPlugin,
void OnSetMusEmbedToken(int instance_id,
const base::UnguessableToken& embed_token);
#endif
void OnSetTooltipText(int browser_plugin_instance_id,
const base::string16& tooltip_text);
void OnShouldAcceptTouchEvents(int instance_id, bool accept);
#if defined(USE_AURA)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment