Skip to content

GitLab

T
tangled
Commit e0099330 authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot
Browse files
Options

Remove sync pseudo-USS from about://flags 

The feature toggles, which have been enabled for some time now, are
about to be removed. As a prior step, we remove them from
about://flags.

Bug: 933874
Change-Id: I121bc774b73cb6dc35436c1438d6eba8d568788d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587568
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654836}
parent a6855700
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 225 deletions
chrome/browser/about_flags.cc
View file @ e0099330
......@@ -3155,55 +3155,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAutofillRichMetadataQueriesName,
flag_descriptions::kAutofillRichMetadataQueriesDescription, kOsAll,
FEATURE_VALUE_TYPE(autofill::features::kAutofillRichMetadataQueries)},
{"enable-sync-pseudo-uss-app-list",
flag_descriptions::kEnableSyncPseudoUSSAppListName,
flag_descriptions::kEnableSyncPseudoUSSAppListDescription, kOsCrOS,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSAppList)},
{"enable-sync-pseudo-uss-apps",
flag_descriptions::kEnableSyncPseudoUSSAppsName,
flag_descriptions::kEnableSyncPseudoUSSAppsDescription, kOsDesktop,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSApps)},
{"enable-sync-pseudo-uss-dictionary",
flag_descriptions::kEnableSyncPseudoUSSDictionaryName,
flag_descriptions::kEnableSyncPseudoUSSDictionaryDescription,
kOsWin | kOsLinux, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSDictionary)},
{"enable-sync-pseudo-uss-extension-settings",
flag_descriptions::kEnableSyncPseudoUSSExtensionSettingsName,
flag_descriptions::kEnableSyncPseudoUSSExtensionSettingsDescription,
kOsDesktop, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSExtensionSettings)},
{"enable-sync-pseudo-uss-extensions",
flag_descriptions::kEnableSyncPseudoUSSExtensionsName,
flag_descriptions::kEnableSyncPseudoUSSExtensionsDescription, kOsDesktop,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSExtensions)},
{"enable-sync-pseudo-uss-favicons",
flag_descriptions::kEnableSyncPseudoUSSFaviconsName,
flag_descriptions::kEnableSyncPseudoUSSFaviconsDescription, kOsAll,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSFavicons)},
{"enable-sync-pseudo-uss-history-delete-directives",
flag_descriptions::kEnableSyncPseudoUSSHistoryDeleteDirectivesName,
flag_descriptions::kEnableSyncPseudoUSSHistoryDeleteDirectivesDescription,
kOsAll,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSHistoryDeleteDirectives)},
{"enable-sync-pseudo-uss-preferences",
flag_descriptions::kEnableSyncPseudoUSSPreferencesName,
flag_descriptions::kEnableSyncPseudoUSSPreferencesDescription, kOsAll,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPreferences)},
{"enable-sync-pseudo-uss-priority-preferences",
flag_descriptions::kEnableSyncPseudoUSSPriorityPreferencesName,
flag_descriptions::kEnableSyncPseudoUSSPriorityPreferencesDescription,
kOsAll, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPriorityPreferences)},
{"enable-sync-pseudo-uss-search-engines",
flag_descriptions::kEnableSyncPseudoUSSSearchEnginesName,
flag_descriptions::kEnableSyncPseudoUSSSearchEnginesDescription,
kOsDesktop, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSSearchEngines)},
{"enable-sync-pseudo-uss-supervised-users",
flag_descriptions::kEnableSyncPseudoUSSSupervisedUsersName,
flag_descriptions::kEnableSyncPseudoUSSSupervisedUsersDescription, kOsAll,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSSupervisedUsers)},
{"enable-sync-pseudo-uss-themes",
flag_descriptions::kEnableSyncPseudoUSSThemesName,
flag_descriptions::kEnableSyncPseudoUSSThemesDescription, kOsDesktop,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSThemes)},
{"enable-experimental-productivity-features",
flag_descriptions::kExperimentalProductivityFeaturesName,
flag_descriptions::kExperimentalProductivityFeaturesDescription, kOsAll,
......
chrome/browser/flag_descriptions.cc
View file @ e0099330
......@@ -875,74 +875,6 @@ const char kEnableSensorContentSettingName[] = "Sensor content setting";
const char kEnableSensorContentSettingDescription[] =
"Enable UI in content settings to control access to the sensor APIs.";
const char kEnableSyncPseudoUSSAppListName[] =
"Enable pseudo-USS for APP_LIST sync.";
const char kEnableSyncPseudoUSSAppListDescription[] =
"Enable new USS-based codepath for sync datatype APP_LIST.";
const char kEnableSyncPseudoUSSAppsName[] = "Enable pseudo-USS for APPS sync.";
const char kEnableSyncPseudoUSSAppsDescription[] =
"Enable new USS-based codepath for sync datatype APPS.";
const char kEnableSyncPseudoUSSDictionaryName[] =
"Enable pseudo-USS for DICTIONARY sync.";
const char kEnableSyncPseudoUSSDictionaryDescription[] =
"Enable new USS-based codepath for sync datatype DICTIONARY.";
const char kEnableSyncPseudoUSSExtensionSettingsName[] =
"Enable pseudo-USS for EXTENSION_SETTINGS and APP_SETTINGS sync.";
const char kEnableSyncPseudoUSSExtensionSettingsDescription[] =
"Enable new USS-based codepath for sync datatypes EXTENSION_SETTINGS and "
"APP_SETTINGS.";
const char kEnableSyncPseudoUSSExtensionsName[] =
"Enable pseudo-USS for EXTENSIONS sync.";
const char kEnableSyncPseudoUSSExtensionsDescription[] =
"Enable new USS-based codepath for sync datatype EXTENSIONS.";
const char kEnableSyncPseudoUSSFaviconsName[] =
"Enable pseudo-USS for favicon sync.";
const char kEnableSyncPseudoUSSFaviconsDescription[] =
"Enable new USS-based codepath for sync datatypes FAVICON_IMAGES and "
"FAVICON_TRACKING.";
const char kEnableSyncPseudoUSSHistoryDeleteDirectivesName[] =
"Enable pseudo-USS for HISTORY_DELETE_DIRECTIVES sync.";
const char kEnableSyncPseudoUSSHistoryDeleteDirectivesDescription[] =
"Enable new USS-based codepath for sync datatype "
"HISTORY_DELETE_DIRECTIVES.";
const char kEnableSyncPseudoUSSPasswordsName[] =
"Enable pseudo-USS for PASSWORDS sync.";
const char kEnableSyncPseudoUSSPasswordsDescription[] =
"Enable new USS-based codepath for sync datatype PASSWORDS (pseudo-USS).";
const char kEnableSyncPseudoUSSPreferencesName[] =
"Enable pseudo-USS for PREFERENCES sync.";
const char kEnableSyncPseudoUSSPreferencesDescription[] =
"Enable new USS-based codepath for sync datatype PREFERENCES.";
const char kEnableSyncPseudoUSSPriorityPreferencesName[] =
"Enable pseudo-USS for PRIORITY_PREFERENCES sync.";
const char kEnableSyncPseudoUSSPriorityPreferencesDescription[] =
"Enable new USS-based codepath for sync datatype PRIORITY_PREFERENCES.";
const char kEnableSyncPseudoUSSSearchEnginesName[] =
"Enable pseudo-USS for SEARCH_ENGINES sync.";
const char kEnableSyncPseudoUSSSearchEnginesDescription[] =
"Enable new USS-based codepath for sync datatype SEARCH_ENGINES.";
const char kEnableSyncPseudoUSSSupervisedUsersName[] =
"Enable pseudo-USS for supervised users sync.";
const char kEnableSyncPseudoUSSSupervisedUsersDescription[] =
"Enable new USS-based codepath for sync datatypes SUPERVISED_USER_SETTINGS "
"and SUPERVISED_USER_WHITELISTS.";
const char kEnableSyncPseudoUSSThemesName[] =
"Enable pseudo-USS for THEMES sync.";
const char kEnableSyncPseudoUSSThemesDescription[] =
"Enable new USS-based codepath for sync datatype THEMES.";
const char kEnableSyncUSSBookmarksName[] = "Enable USS for bookmarks sync";
const char kEnableSyncUSSBookmarksDescription[] =
"Enables the new, experimental implementation of bookmark sync";
......
chrome/browser/flag_descriptions.h
View file @ e0099330
......@@ -525,45 +525,6 @@ extern const char kEnableResourceLoadingHintsDescription[];
extern const char kEnableSensorContentSettingName[];
extern const char kEnableSensorContentSettingDescription[];
extern const char kEnableSyncPseudoUSSAppListName[];
extern const char kEnableSyncPseudoUSSAppListDescription[];
extern const char kEnableSyncPseudoUSSAppsName[];
extern const char kEnableSyncPseudoUSSAppsDescription[];
extern const char kEnableSyncPseudoUSSDictionaryName[];
extern const char kEnableSyncPseudoUSSDictionaryDescription[];
extern const char kEnableSyncPseudoUSSExtensionSettingsName[];
extern const char kEnableSyncPseudoUSSExtensionSettingsDescription[];
extern const char kEnableSyncPseudoUSSExtensionsName[];
extern const char kEnableSyncPseudoUSSExtensionsDescription[];
extern const char kEnableSyncPseudoUSSFaviconsName[];
extern const char kEnableSyncPseudoUSSFaviconsDescription[];
extern const char kEnableSyncPseudoUSSHistoryDeleteDirectivesName[];
extern const char kEnableSyncPseudoUSSHistoryDeleteDirectivesDescription[];
extern const char kEnableSyncPseudoUSSPasswordsName[];
extern const char kEnableSyncPseudoUSSPasswordsDescription[];
extern const char kEnableSyncPseudoUSSPreferencesName[];
extern const char kEnableSyncPseudoUSSPreferencesDescription[];
extern const char kEnableSyncPseudoUSSPriorityPreferencesName[];
extern const char kEnableSyncPseudoUSSPriorityPreferencesDescription[];
extern const char kEnableSyncPseudoUSSSearchEnginesName[];
extern const char kEnableSyncPseudoUSSSearchEnginesDescription[];
extern const char kEnableSyncPseudoUSSSupervisedUsersName[];
extern const char kEnableSyncPseudoUSSSupervisedUsersDescription[];
extern const char kEnableSyncPseudoUSSThemesName[];
extern const char kEnableSyncPseudoUSSThemesDescription[];
extern const char kEnableSyncUSSBookmarksName[];
extern const char kEnableSyncUSSBookmarksDescription[];
......
ios/chrome/browser/about_flags.mm
View file @ e0099330
......@@ -429,33 +429,6 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
{"non-modal-dialogs", flag_descriptions::kNonModalDialogsName,
flag_descriptions::kNonModalDialogsDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(dialogs::kNonModalDialogs)},
{"sync-pseudo-uss-favicons", flag_descriptions::kSyncPseudoUSSFaviconsName,
flag_descriptions::kSyncPseudoUSSFaviconsDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSFavicons)},
{"sync-pseudo-uss-history-delete-directives",
flag_descriptions::kSyncPseudoUSSHistoryDeleteDirectivesName,
flag_descriptions::kSyncPseudoUSSHistoryDeleteDirectivesDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSHistoryDeleteDirectives)},
{"sync-pseudo-uss-preferences",
flag_descriptions::kSyncPseudoUSSPreferencesName,
flag_descriptions::kSyncPseudoUSSPreferencesDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPreferences)},
{"sync-pseudo-uss-priority-preferences",
flag_descriptions::kSyncPseudoUSSPriorityPreferencesName,
flag_descriptions::kSyncPseudoUSSPriorityPreferencesDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPriorityPreferences)},
{"use-nsurlsession-for-signin",
flag_descriptions::kUseNSURLSessionForGaiaSigninRequestsName,
flag_descriptions::kUseNSURLSessionForGaiaSigninRequestsDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kUseNSURLSessionForGaiaSigninRequests)},
{"sync-pseudo-uss-supervised-users",
flag_descriptions::kSyncPseudoUSSSupervisedUsersName,
flag_descriptions::kSyncPseudoUSSSupervisedUsersDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSSupervisedUsers)},
{"detect-main-thread-freeze",
flag_descriptions::kDetectMainThreadFreezeName,
flag_descriptions::kDetectMainThreadFreezeDescription, flags_ui::kOsIos,
......
ios/chrome/browser/ios_chrome_flag_descriptions.cc
View file @ e0099330
......@@ -96,33 +96,6 @@ const char kEnableSyncUSSPasswordsName[] = "Enable USS for passwords sync";
const char kEnableSyncUSSPasswordsDescription[] =
"Enables the new, experimental implementation of password sync";
const char kSyncPseudoUSSFaviconsName[] = "Enable pseudo-USS for favicon sync.";
const char kSyncPseudoUSSFaviconsDescription[] =
"Enable new USS-based codepath for sync datatypes FAVICON_IMAGES and "
"FAVICON_TRACKING.";
const char kSyncPseudoUSSHistoryDeleteDirectivesName[] =
"Enable pseudo-USS for HISTORY_DELETE_DIRECTIVES sync.";
const char kSyncPseudoUSSHistoryDeleteDirectivesDescription[] =
"Enable new USS-based codepath for sync datatype "
"HISTORY_DELETE_DIRECTIVES.";
const char kSyncPseudoUSSPreferencesName[] =
"Enable pseudo-USS for PREFERENCES sync.";
const char kSyncPseudoUSSPreferencesDescription[] =
"Enable new USS-based codepath for sync datatype PREFERENCES.";
const char kSyncPseudoUSSPriorityPreferencesName[] =
"Enable pseudo-USS for PRIORITY_PREFERENCES sync.";
const char kSyncPseudoUSSPriorityPreferencesDescription[] =
"Enable new USS-based codepath for sync datatype PRIORITY_PREFERENCES.";
const char kSyncPseudoUSSSupervisedUsersName[] =
"Enable pseudo-USS for supervised users sync.";
const char kSyncPseudoUSSSupervisedUsersDescription[] =
"Enable new USS-based codepath for sync datatypes SUPERVISED_USER_SETTINGS "
"and SUPERVISED_USER_WHITELISTS.";
const char kSyncSandboxName[] = "Use Chrome Sync sandbox";
const char kSyncSandboxDescription[] =
"Connects to the testing server for Chrome Sync.";
......
ios/chrome/browser/ios_chrome_flag_descriptions.h
View file @ e0099330
......@@ -78,21 +78,6 @@ extern const char kEnableSyncUSSBookmarksDescription[];
extern const char kEnableSyncUSSPasswordsName[];
extern const char kEnableSyncUSSPasswordsDescription[];
extern const char kSyncPseudoUSSFaviconsName[];
extern const char kSyncPseudoUSSFaviconsDescription[];
extern const char kSyncPseudoUSSHistoryDeleteDirectivesName[];
extern const char kSyncPseudoUSSHistoryDeleteDirectivesDescription[];
extern const char kSyncPseudoUSSPreferencesName[];
extern const char kSyncPseudoUSSPreferencesDescription[];
extern const char kSyncPseudoUSSPriorityPreferencesName[];
extern const char kSyncPseudoUSSPriorityPreferencesDescription[];
extern const char kSyncPseudoUSSSupervisedUsersName[];
extern const char kSyncPseudoUSSSupervisedUsersDescription[];
// Title and description for the flag to control if Chrome Sync should use the
// sandbox servers.
extern const char kSyncSandboxName[];
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment