Skip to content

GitLab

T
tangled
Commit e02b6826 authored by Naina Raisinghani's avatar Naina Raisinghani Committed by Commit Bot
Browse files
Options

[css-typed-om] Move inline style map layout tests to WPT. 

We used to have some inline style map layout tests for a subset of
properties. This patch moves them to WPT using the new test harness.

Properties added:
- white-space
- vertical-align
- visibility
- z-index

Bug: 774887
Change-Id: Icce056c4d7f56eed3da05834b1c561fddec53a15
Reviewed-on: https://chromium-review.googlesource.com/918203
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536966}
parent 47eff284
Hide whitespace changes
Inline Side-by-side
Showing with 93 additions and 0 deletions
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/vertical-align.html 0 → 100644
View file @ e02b6826
<!doctype html>
<meta charset="utf-8">
<title>'vertical-align' property</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-get">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-set">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#property-stle-value-normalization">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../../resources/testhelper.js"></script>
<script src="resources/testsuite.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';
runPropertyTests('vertical-align', [
{ syntax: 'baseline'},
// and other keywords
{ syntax: '<length>' },
{ syntax: '<percentage>' }
]);
</script>
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/visibility.html 0 → 100644
View file @ e02b6826
<!doctype html>
<meta charset="utf-8">
<title>'visibility' property</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-get">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-set">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#property-stle-value-normalization">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../../resources/testhelper.js"></script>
<script src="resources/testsuite.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';
runPropertyTests('visibility', [
{ syntax: 'visible'},
{ syntax: 'hidden' }
// and other keywords
]);
</script>
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/white-space.html 0 → 100644
View file @ e02b6826
<!doctype html>
<meta charset="utf-8">
<title>'white-space' property</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-get">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-set">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#property-stle-value-normalization">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../../resources/testhelper.js"></script>
<script src="resources/testsuite.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';
runPropertyTests('white-space', [
{ syntax: 'normal'},
{ syntax: 'nowrap' }
// and other keywords
]);
</script>
third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index.html 0 → 100644
View file @ e02b6826
<!doctype html>
<meta charset="utf-8">
<title>'z-index' property</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-get">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-set">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#property-stle-value-normalization">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../../resources/testhelper.js"></script>
<script src="resources/testsuite.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';
runPropertyTests('z-index', [
{ syntax: 'auto'},
// FIXME: This also supports <integer> but the testharness
// doesn't support that yet.
// { syntax: '<integer>' }
]);
</script>
third_party/WebKit/Source/core/css/CSSProperties.json5
View file @ e02b6826
...@@ -2832,6 +2832,8 @@ ...@@ -2832,6 +2832,8 @@
interpolable: true, interpolable: true,
custom_apply_functions_inherit: true, custom_apply_functions_inherit: true,
custom_apply_functions_value: true, custom_apply_functions_value: true,
typedom_types: ["Length", "Percent"],
keywords: ["baseline", "sub", "super", "text-top", "text-bottom", "middle"],
}, },
{ {
name: "visibility", name: "visibility",
...@@ -3486,6 +3488,7 @@ ...@@ -3486,6 +3488,7 @@
type_name: "int", type_name: "int",
computed_style_custom_functions: ["setter"], computed_style_custom_functions: ["setter"],
custom_apply_functions_all: true, custom_apply_functions_all: true,
keywords: ["auto"],
}, },
// CSS logical props // CSS logical props
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment