Commit e02bb35e authored by Takashi Toyoshima's avatar Takashi Toyoshima Committed by Commit Bot

ResourceLoadScheduler: enabled the feature by default

This patch changes the field study default configurations to be
aligned with parameters that are planned for launch.

Bug: 729954
Change-Id: Idf4cb1097efee62d20a8bd1b2fa67dc872967517
Reviewed-on: https://chromium-review.googlesource.com/1016142
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553493}
parent 2ad20078
...@@ -306,7 +306,7 @@ const base::Feature kRequireCSSExtensionForFile{ ...@@ -306,7 +306,7 @@ const base::Feature kRequireCSSExtensionForFile{
// Loading Dispatcher v0 support with ResourceLoadScheduler (crbug.com/729954). // Loading Dispatcher v0 support with ResourceLoadScheduler (crbug.com/729954).
const base::Feature kResourceLoadScheduler{"ResourceLoadScheduler", const base::Feature kResourceLoadScheduler{"ResourceLoadScheduler",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Use common overflow scroll mechanism for frames. See http://crbug.com/417782. // Use common overflow scroll mechanism for frames. See http://crbug.com/417782.
const base::Feature kRootLayerScrolling{"RootLayerScrolling", const base::Feature kRootLayerScrolling{"RootLayerScrolling",
......
...@@ -29,7 +29,11 @@ const char kOutstandingLimitForBackgroundMainFrameName[] = "bg_limit"; ...@@ -29,7 +29,11 @@ const char kOutstandingLimitForBackgroundMainFrameName[] = "bg_limit";
const char kOutstandingLimitForBackgroundSubFrameName[] = "bg_sub_limit"; const char kOutstandingLimitForBackgroundSubFrameName[] = "bg_sub_limit";
// Field trial default parameters. // Field trial default parameters.
constexpr size_t kOutstandingLimitForBackgroundFrameDefault = 16u; // Note: Giving smaller sub-frame threshold seems to work better for improving
// foreground loading performance, while setting it to 1u easily breaks some
// services that have one long-polling request, and needs other resources.
constexpr size_t kOutstandingLimitForBackgroundMainFrameDefault = 3u;
constexpr size_t kOutstandingLimitForBackgroundSubFrameDefault = 2u;
// Maximum request count that request count metrics assume. // Maximum request count that request count metrics assume.
constexpr base::HistogramBase::Sample kMaximumReportSize10K = 10000; constexpr base::HistogramBase::Sample kMaximumReportSize10K = 10000;
...@@ -95,18 +99,14 @@ size_t GetOutstandingThrottledLimit(FetchContext* context) { ...@@ -95,18 +99,14 @@ size_t GetOutstandingThrottledLimit(FetchContext* context) {
if (!RuntimeEnabledFeatures::ResourceLoadSchedulerEnabled()) if (!RuntimeEnabledFeatures::ResourceLoadSchedulerEnabled())
return ResourceLoadScheduler::kOutstandingUnlimited; return ResourceLoadScheduler::kOutstandingUnlimited;
uint32_t main_frame_limit = GetFieldTrialUint32Param( static size_t main_frame_limit = GetFieldTrialUint32Param(
kResourceLoadSchedulerTrial, kOutstandingLimitForBackgroundMainFrameName, kResourceLoadSchedulerTrial, kOutstandingLimitForBackgroundMainFrameName,
kOutstandingLimitForBackgroundFrameDefault); kOutstandingLimitForBackgroundMainFrameDefault);
if (context->IsMainFrame()) static size_t sub_frame_limit = GetFieldTrialUint32Param(
return main_frame_limit; kResourceLoadSchedulerTrial, kOutstandingLimitForBackgroundSubFrameName,
kOutstandingLimitForBackgroundSubFrameDefault);
// We do not have a fixed default limit for sub-frames, but use the limit for
// the main frame so that it works as how previous versions that haven't return context->IsMainFrame() ? main_frame_limit : sub_frame_limit;
// consider sub-frames' specific limit work.
return GetFieldTrialUint32Param(kResourceLoadSchedulerTrial,
kOutstandingLimitForBackgroundSubFrameName,
main_frame_limit);
} }
int TakeWholeKilobytes(int64_t& bytes) { int TakeWholeKilobytes(int64_t& bytes) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment