Commit e042ef93 authored by Harley Li's avatar Harley Li Committed by Commit Bot

[DevTools] Add clarification in blackbox setting tab

Bug: 818855
Change-Id: I9f626a01d9188ae25e82bc4d2a6201f20c90e621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622714Reviewed-by: default avatarErik Luo <luoe@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662880}
parent 61a51a16
......@@ -12,10 +12,14 @@ Settings.FrameworkBlackboxSettingsTab = class extends UI.VBox {
super(true);
this.registerRequiredCSS('settings/frameworkBlackboxSettingsTab.css');
this.contentElement.createChild('div', 'header').textContent = Common.UIString('Framework Blackbox Patterns');
this.contentElement.createChild('div', 'blackbox-content-scripts')
.appendChild(UI.SettingsUI.createSettingCheckbox(
Common.UIString('Blackbox content scripts'), Common.moduleSetting('skipContentScripts'), true));
this.contentElement.createChild('div', 'header').textContent = Common.UIString('Framework Blackboxing');
this.contentElement.createChild('div', 'intro').textContent =
ls`Debugger will skip through the scripts and will not stop on exceptions thrown by them.`;
const blackboxContentScripts = this.contentElement.createChild('div', 'blackbox-content-scripts');
blackboxContentScripts.appendChild(UI.SettingsUI.createSettingCheckbox(
ls`Blackbox content scripts`, Common.moduleSetting('skipContentScripts'), true));
blackboxContentScripts.title = ls`Blackbox content scripts (extension scripts in the page)`;
this._blackboxLabel = Common.UIString('Blackbox');
this._disabledLabel = Common.UIString('Disabled');
......@@ -68,7 +72,8 @@ Settings.FrameworkBlackboxSettingsTab = class extends UI.VBox {
const element = createElementWithClass('div', 'blackbox-list-item');
const pattern = element.createChild('div', 'blackbox-pattern');
pattern.textContent = item.pattern;
pattern.title = item.pattern;
pattern.title = ls`Blackbox scripts whose names match` +
' \'' + item.pattern + '\'';
element.createChild('div', 'blackbox-separator');
element.createChild('div', 'blackbox-behavior').textContent =
item.disabled ? this._disabledLabel : this._blackboxLabel;
......
......@@ -16,6 +16,10 @@
flex: none;
}
.intro {
margin-top: 10px;
}
.blackbox-content-scripts {
margin-top: 10px;
flex: none;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment