Commit e05f4529 authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

Avoid having two SendReport functions to not confuse Bind(..).

In certain (extreme) jumbo build configurations, SendReport in
chrome/browser/net/chrome_report_sender.h and
chrome/browser/net/trial_comparison_cert_verifier.cc ended up as
symbols in the same translation unit and then the address
operator didn't know which function to refer to in a Bind(...) call.

This renames the local SendReport in
net/trial_comparison_cert_verifier.cc to SendCertVerifyReport.

Change-Id: I9cc17beb509452f66f5620cf7ea4ca4f1f04ed33
Reviewed-on: https://chromium-review.googlesource.com/992495
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: default avatarMatt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548012}
parent 1c5e7cf7
......@@ -75,10 +75,10 @@ bool CheckTrialEligibility(void* profile_id,
return allowed;
}
void SendReport(void* profile_id,
const net::CertVerifier::RequestParams& params,
const net::CertVerifyResult& primary_result,
const net::CertVerifyResult& trial_result) {
void SendTrialVerificationReport(void* profile_id,
const net::CertVerifier::RequestParams& params,
const net::CertVerifyResult& primary_result,
const net::CertVerifyResult& trial_result) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!g_browser_process->profile_manager()->IsValidProfile(profile_id))
return;
......@@ -194,8 +194,9 @@ class TrialComparisonCertVerifier::TrialVerificationJob {
}
content::BrowserThread::GetTaskRunnerForThread(content::BrowserThread::UI)
->PostTask(FROM_HERE, base::BindOnce(&SendReport, profile_id_, params_,
primary_result_, trial_result_));
->PostTask(FROM_HERE,
base::BindOnce(&SendTrialVerificationReport, profile_id_,
params_, primary_result_, trial_result_));
}
void OnJobCompleted(int trial_result_error) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment