[bfcache] Disable BackForwardCache for pages with media players.

This patch prevents the BackForwardCache from caching pages that want to
play media.

My understanding is that MediaWebContentsObserver has an indexed map of
RenderFrameHost to MediaSessionController via its delegate member
MediaSessionControllerManager.

These get added in MediaWebContentsObserver::OnMediaPlaying and sometimes
removed by observing WebContents::RenderFrameHostDeleted.

With the BackForwardCache we do not get this last event and are left in
a non-valid state, so we proactively disable caching for pages involved
with media.

More details on why we sometimes need to disable bfcache:
https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8

Change-Id: Ibaa3040c9118a8a8dc5f1ad0f0f8d2dbd4609cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832208
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704165}

content/browser/media/media_web_contents_observer.cc

@@ -220,6 +220,9 @@ void MediaWebContentsObserver::OnMediaPlaying(
   if (is_remote)
     return;
 
+  BackForwardCache::DisableForRenderFrameHost(
+      render_frame_host, "MediaWebContentsObserver::OnMediaPlaying");
+
   const MediaPlayerId id(render_frame_host, delegate_id);
   if (has_audio)
     AddMediaPlayerEntry(id, &active_audio_players_);

testing/buildbot/filters/bfcache.chrome_public_test_apk.filter

@@ -22,7 +22,6 @@
 -org.chromium.chrome.browser.infobar.InfoBarTest.testInfoBarForGeolocationDisappearsOnBack
 -org.chromium.chrome.browser.keyboard_accessory.PasswordGenerationIntegrationTest.testAutomaticGenerationUsePassword
 -org.chromium.chrome.browser.keyboard_accessory.PasswordGenerationIntegrationTest.testManualGenerationUsePassword
--org.chromium.chrome.browser.media.*
 -org.chromium.chrome.browser.notifications.NotificationPlatformBridgeIntentTest.testLaunchNotificationPreferencesForCategory
 -org.chromium.chrome.browser.notifications.NotificationPlatformBridgeIntentTest.testLaunchNotificationPreferencesForWebsite
 -org.chromium.chrome.browser.offlinepages.*

testing/buildbot/filters/bfcache.content_browsertests.filter

@@ -95,17 +95,13 @@
 # Failing on android only, need to be triaged, see https://crbug.com/1006267.
 -BackForwardCacheMetricsBrowserTest.Fetch
 -BackForwardCacheMetricsBrowserTest.XHR
+-WebContentsSplitCacheBrowserTestEnabled.SplitCache*
 -WebRtcBrowserTest.CanSetupH264VideoCallOnSupportedDevice
 -WithoutCORBProtectionSniffing/CrossSiteDocumentBlockingTest.*
 -WithCORBProtectionSniffing/CrossSiteDocumentBlockingTest.*
 
 # Flaky on android only, need to be triaged, see https://crbug.com/1006267.
 -IndexedDBBrowserTest*
--MediaCanPlayTypeTest.*
--MediaSessionImplBrowserTest.*
--MediaSessionImplParamBrowserTest.*
--MediaSourceTest.*
--MidiBrowserTest.*
 -MHTMLGenerationTest/MHTMLGenerationTest.*
 -MSE_ClearKey/EncryptedMediaTest.*
 -MSE_ExternalClearKey/EncryptedMediaTest.*

testing/buildbot/filters/bfcache.content_unittests.filter

@@ -49,10 +49,5 @@
 -GeolocationServiceTest.*
 -MediaInternalsAudioLogTest/MediaInternalsAudioLogTest.*
 -MediaInternalsVideoCaptureDeviceTest.NotifyVideoCaptureDeviceCapabilitiesEnumerated
--MediaSessionControllerTest.*
--MediaSessionEnabledTestInstances/MediaSessionControllersManagerTest.*
--MediaSessionImplServiceRoutingTest.*
--MediaSessionImplTest.*
--MediaSessionImplUmaTest.*
 -MediaStreamManagerTest.*
 -RenderFrameAudioOutputStreamFactoryTest.*

testing/buildbot/filters/bfcache.unit_tests.filter

@@ -19,6 +19,5 @@
 -CreditCardAccessoryControllerTest.ServerCardUnmask
 
 # Other failures
--MediaDrmOriginIdManagerTest.NetworkChangeFails
 -OfflinePageUtilsTest.*
 -PreviewsUKMObserverTest.TestPageEndReasonUMA