Commit e0882f07 authored by Nicolas Ouellet-Payeur's avatar Nicolas Ouellet-Payeur Committed by Commit Bot

[Traffic Annotations] Enable extractor.py on CQ

The `check_network_annotations' step on CQ now uses the `python_script'
backend instead of the `clang_tool' backend, making it much faster and
(hopefully) less flaky.

Also changes the default backend to `python_script', when running
traffic_annotation_auditor.exe locally.

Bug: 966883
Change-Id: Icc608a15608418328774019d3ef25994201e3104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762747Reviewed-by: default avatarRamin Halavati <rhalavati@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691612}
parent 1eefeb0a
......@@ -133,9 +133,9 @@ std::string UpdateTextForTSV(std::string text) {
}
ExtractorBackend GetExtractorBackend(const std::string& backend_switch) {
if (backend_switch.empty() || backend_switch == "clang_tool")
if (backend_switch == "clang_tool")
return ExtractorBackend::CLANG_TOOL;
if (backend_switch == "python_script")
if (backend_switch.empty() || backend_switch == "python_script")
return ExtractorBackend::PYTHON_SCRIPT;
return ExtractorBackend::INVALID;
}
......
......@@ -75,4 +75,4 @@ The following two lines will be updated by the above script, and the modified
README should be committed along with the updated .sha1 checksums.
CLANG_REVISION = '8288453f6aac05080b751b680455349e09d49825'
LASTCHANGE=f2c1c7345ba6ae08339770e312304168c04f10c9-refs/heads/master@{#691112}
LASTCHANGE=1f619bc51ddddccc493776c0d2d3596d1c758a28-refs/heads/master@{#691147}
bfe65b4c8c1f0285728631894a104dc8414da7ee
\ No newline at end of file
eee0f2d9b6f83e03206912c748132495a21b5e37
\ No newline at end of file
2390166409ac2d4a87539ceefc99f56a6a68b105
\ No newline at end of file
1709431c1a680a1d3880b4d9852c7d3d1a7e3661
\ No newline at end of file
......@@ -52,18 +52,30 @@ class TrafficAnnotationTestsChecker():
"""
configs = [
["--test-only", "--error-resilient"], # Similar to trybot.
["--test-only"], # Failing on any runtime error.
["--test-only", "--no-filtering"], # Not using heuristic filtering.
[ # extractor.py.
[ # Similar to trybot.
"--test-only",
"--error-resilient",
"--extractor-backend=python_script",
],
[ # extractor.py, no filtering.
[ # Failing on any runtime error.
"--test-only",
"--extractor-backend=python_script",
],
[ # No heuristic filtering.
"--test-only",
"--no-filtering",
"--extractor-backend=python_script",
],
[ # Clang tool backend.
"--test-only",
"--extractor-backend=clang_tool",
],
[ # Clang tool backend, no heuristic filtering.
"--test-only",
"--no-filtering",
"--extractor-backend=clang_tool",
],
]
self.last_result = None
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment