Skip to content

GitLab

T
tangled
Commit e08be372 authored by Aleks Totic's avatar Aleks Totic Committed by Commit Bot
Browse files
Options

[LayoutNG] Minor inline container DCHECK fix 

We already had a fix for inline, misssed fixing
it for block.

Bug: 967977
Change-Id: Iad883eca7761f0db203fc6e01d48466d7b09dfd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648299Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667249}
parent 7054d64a
Hide whitespace changes
Inline Side-by-side
Showing with 19 additions and 1 deletion
third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
View file @ e08be372
...@@ -364,7 +364,8 @@ void NGOutOfFlowLayoutPart::ComputeInlineContainingBlocks( ...@@ -364,7 +364,8 @@ void NGOutOfFlowLayoutPart::ComputeInlineContainingBlocks(
// Make sure we don't end up with a rectangle with "negative" size. // Make sure we don't end up with a rectangle with "negative" size.
end_offset.inline_offset = end_offset.inline_offset =
std::max(end_offset.inline_offset, start_offset.inline_offset); std::max(end_offset.inline_offset, start_offset.inline_offset);
end_offset.block_offset =
std::max(end_offset.block_offset, start_offset.block_offset);
// Step 3 - determine the logical rectangle. // Step 3 - determine the logical rectangle.
// Determine the logical size of the containing block. // Determine the logical size of the containing block.
......
third_party/blink/web_tests/external/wpt/css/css-position/position-absolute-crash-chrome-008.html 0 → 100644
View file @ e08be372
<!DOCTYPE html>
<link rel="author" href="mailto:atotic@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="help" href="https://crbug.com/967977">
<meta name="assert" content="zero width inline abspos container with borders does not cause a crash">
<style>
</style>
<span style="border-bottom:1px solid; filter:blur(2px);">
<div style="position:absolute"></div>
</span>
<script>
document.body.offsetTop;
test(() => {
}, 'test passes if it does not crash');
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment