2009-04-21 Dave Moore <davemoore@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25309
        Better use AtomicStrings when calling from the V8
        bindings into WebCore code.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/WebCore/ChangeLog

+2009-04-21  Dave Moore  <davemoore@google.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25309
+        Better use AtomicStrings when calling from the V8
+        bindings into WebCore code.
+
+        * bindings/v8/custom/V8DOMWindowCustom.cpp:
+        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
+        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
+
 2009-04-21  Chris Fleizach  <cfleizach@apple.com>
 
         Reviewed by Darin Adler.

third_party/WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

@@ -540,9 +540,6 @@ INDEXED_PROPERTY_GETTER(DOMWindow)
 NAMED_PROPERTY_GETTER(DOMWindow)
 {
     INC_STATS("DOM.DOMWindow.NamedPropertyGetter");
-    // The key must be a string.
-    if (!name->IsString())
-        return notHandledByInterceptor();
 
     v8::Handle<v8::Object> holder = V8Proxy::LookupDOMWrapper(V8ClassIndex::DOMWINDOW, info.This());
     if (holder.IsEmpty())
@@ -552,14 +549,13 @@ NAMED_PROPERTY_GETTER(DOMWindow)
     if (!window)
         return notHandledByInterceptor();
 
-    String propName = toWebCoreString(name);
-
     Frame* frame = window->frame();
     // window is detached from a frame.
     if (!frame)
         return notHandledByInterceptor();
 
     // Search sub-frames.
+    AtomicString propName = v8StringToAtomicWebCoreString(name);
     Frame* child = frame->tree()->child(propName);
     if (child)
         return V8Proxy::ToV8Object(V8ClassIndex::DOMWINDOW, child->domWindow());
@@ -622,7 +618,7 @@ NAMED_PROPERTY_GETTER(DOMWindow)
         // TODO(ager): We probably should implement the Has method
         // for the interceptor instead of using the default Has method
         // that calls Get.
-        context->Global()->Set(v8String(propName), v8::Undefined());
+        context->Global()->Set(name, v8::Undefined());
         V8Proxy* proxy = V8Proxy::retrieve(window->frame());
         ASSERT(proxy);
 

third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

@@ -38,7 +38,7 @@
 
 namespace WebCore {
 
-static v8::Handle<v8::Value> getNamedItems(HTMLCollection* collection, String name)
+static v8::Handle<v8::Value> getNamedItems(HTMLCollection* collection, AtomicString name)
 {
     Vector<RefPtr<Node> > namedItems;
     collection->namedItems(name, namedItems);
@@ -85,7 +85,7 @@ NAMED_PROPERTY_GETTER(HTMLCollection)
 
     // Finally, search the DOM structure.
     HTMLCollection* imp = V8Proxy::ToNativeObject<HTMLCollection>(V8ClassIndex::HTMLCOLLECTION, info.Holder());
-    return getNamedItems(imp, toWebCoreString(name));
+    return getNamedItems(imp, v8StringToAtomicWebCoreString(name));
 }
 
 CALLBACK_FUNC_DECL(HTMLCollectionItem)

third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp

@@ -42,7 +42,7 @@ NAMED_PROPERTY_GETTER(HTMLFormElement)
 {
     INC_STATS("DOM.HTMLFormElement.NamedPropertyGetter");
     HTMLFormElement* imp = V8Proxy::DOMWrapperToNode<HTMLFormElement>(info.Holder());
-    String v = toWebCoreString(name);
+    AtomicString v = v8StringToAtomicWebCoreString(name);
 
     // Call getNamedElements twice, first time check if it has a value
     // and let HTMLFormElement update its cache.

third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

@@ -48,7 +48,7 @@ NAMED_PROPERTY_GETTER(HTMLFrameSetElement)
 {
     INC_STATS("DOM.HTMLFrameSetElement.NamedPropertyGetter");
     HTMLFrameSetElement* imp = V8Proxy::DOMWrapperToNode<HTMLFrameSetElement>(info.Holder());
-    Node* frameNode = imp->children()->namedItem(toWebCoreString(name));
+    Node* frameNode = imp->children()->namedItem(v8StringToAtomicWebCoreString(name));
     if (frameNode && frameNode->hasTagName(HTMLNames::frameTag)) {
         Document* doc = static_cast<HTMLFrameElement*>(frameNode)->contentDocument();
         if (!doc)