Commit e0b09aef authored by Takashi Toyoshima's avatar Takashi Toyoshima Committed by Chromium LUCI CQ

Remove WebFont.MissedCache.DownloadTime.*

Remove unused WebFont related metrics,
WebFont.MissedCache.DownloadTime.*.

Bug: 1156195
Change-Id: Ic26e5479737534167aeaf85f1c94e302dcadb00a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592229Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845061}
parent 416fbe44
...@@ -468,51 +468,27 @@ void RemoteFontFaceSource::FontLoadHistograms::RecordLoadTimeHistogram( ...@@ -468,51 +468,27 @@ void RemoteFontFaceSource::FontLoadHistograms::RecordLoadTimeHistogram(
// bucket. // bucket.
if (font->ErrorOccurred()) { if (font->ErrorOccurred()) {
base::UmaHistogramTimes("WebFont.DownloadTime.LoadError", delta); base::UmaHistogramTimes("WebFont.DownloadTime.LoadError", delta);
if (data_source_ == kFromNetwork) {
base::UmaHistogramTimes("WebFont.MissedCache.DownloadTime.LoadError",
delta);
}
return; return;
} }
size_t size = font->EncodedSize(); size_t size = font->EncodedSize();
if (size < 10 * 1024) { if (size < 10 * 1024) {
base::UmaHistogramTimes("WebFont.DownloadTime.0.Under10KB", delta); base::UmaHistogramTimes("WebFont.DownloadTime.0.Under10KB", delta);
if (data_source_ == kFromNetwork) {
base::UmaHistogramTimes("WebFont.MissedCache.DownloadTime.0.Under10KB",
delta);
}
return; return;
} }
if (size < 50 * 1024) { if (size < 50 * 1024) {
base::UmaHistogramTimes("WebFont.DownloadTime.1.10KBTo50KB", delta); base::UmaHistogramTimes("WebFont.DownloadTime.1.10KBTo50KB", delta);
if (data_source_ == kFromNetwork) {
base::UmaHistogramTimes("WebFont.MissedCache.DownloadTime.1.10KBTo50KB",
delta);
}
return; return;
} }
if (size < 100 * 1024) { if (size < 100 * 1024) {
base::UmaHistogramTimes("WebFont.DownloadTime.2.50KBTo100KB", delta); base::UmaHistogramTimes("WebFont.DownloadTime.2.50KBTo100KB", delta);
if (data_source_ == kFromNetwork) {
base::UmaHistogramTimes("WebFont.MissedCache.DownloadTime.2.50KBTo100KB",
delta);
}
return; return;
} }
if (size < 1024 * 1024) { if (size < 1024 * 1024) {
base::UmaHistogramTimes("WebFont.DownloadTime.3.100KBTo1MB", delta); base::UmaHistogramTimes("WebFont.DownloadTime.3.100KBTo1MB", delta);
if (data_source_ == kFromNetwork) {
base::UmaHistogramTimes("WebFont.MissedCache.DownloadTime.3.100KBTo1MB",
delta);
}
return; return;
} }
base::UmaHistogramTimes("WebFont.DownloadTime.4.Over1MB", delta); base::UmaHistogramTimes("WebFont.DownloadTime.4.Over1MB", delta);
if (data_source_ == kFromNetwork) {
base::UmaHistogramTimes("WebFont.MissedCache.DownloadTime.4.Over1MB",
delta);
}
} }
RemoteFontFaceSource::FontLoadHistograms::CacheHitMetrics RemoteFontFaceSource::FontLoadHistograms::CacheHitMetrics
......
...@@ -19664,7 +19664,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -19664,7 +19664,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram_suffixes name="WebFontMissedCache" separator="." ordering="prefix"> <histogram_suffixes name="WebFontMissedCache" separator="." ordering="prefix">
<owner>toyoshim@chromium.org</owner> <owner>toyoshim@chromium.org</owner>
<suffix name="MissedCache" label="On missed cache"/> <suffix name="MissedCache" label="On missed cache">
<obsolete>
Removed Dec 2020.
</obsolete>
</suffix>
<affected-histogram name="WebFont.DownloadTime.0.Under10KB"/> <affected-histogram name="WebFont.DownloadTime.0.Under10KB"/>
<affected-histogram name="WebFont.DownloadTime.1.10KBTo50KB"/> <affected-histogram name="WebFont.DownloadTime.1.10KBTo50KB"/>
<affected-histogram name="WebFont.DownloadTime.2.50KBTo100KB"/> <affected-histogram name="WebFont.DownloadTime.2.50KBTo100KB"/>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment