Move InstallerDelegateTest from ChromeShellTest to ChromePublicTest

This CL makes InstallerDelegateTest an instrumentation test and moves it to
ChromePublicTest.

BUG=505040
TEST=None
TBR=dfalcantara

Review URL: https://codereview.chromium.org/1228353007

Cr-Commit-Position: refs/heads/master@{#339751}

chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java

@@ -11,6 +11,8 @@ import android.os.Looper;
 import android.os.SystemClock;
 import android.text.TextUtils;
 
+import org.chromium.base.VisibleForTesting;
+
 import java.util.List;
 
 /**
@@ -131,6 +133,7 @@ public class InstallerDelegate implements Runnable {
      * Checks to see if the Runnable will continue scheduling itself.
      * @return True if the runnable is still being scheduled.
      */
+    @VisibleForTesting
     boolean isRunning() {
         return mIsRunning;
     }
@@ -140,6 +143,7 @@ public class InstallerDelegate implements Runnable {
      * @param msBetween How long to wait between executions of the Runnable.
      * @param msMax     How long to wait before giving up.
      */
+    @VisibleForTesting
     void setTimingForTests(long msBetween, long msMax) {
         mMsBetweenRuns = msBetween;
         mMsMaximumWaitingTime = msMax;

chrome/android/javatests_shell/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java → chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

@@ -6,10 +6,10 @@ package org.chromium.chrome.browser.banners;
 
 import android.content.pm.PackageInfo;
 import android.os.HandlerThread;
+import android.test.InstrumentationTestCase;
 import android.test.mock.MockPackageManager;
 import android.test.suitebuilder.annotation.SmallTest;
 
-import org.chromium.chrome.shell.ChromeShellTestBase;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 
@@ -20,7 +20,7 @@ import java.util.List;
  * Tests the InstallerDelegate to make sure that it functions correctly and responds to changes
  * in the PackageManager.
  */
-public class InstallerDelegateTest extends ChromeShellTestBase
+public class InstallerDelegateTest extends InstrumentationTestCase
         implements InstallerDelegate.Observer{
     private static final String MOCK_PACKAGE_NAME = "mock.package.name";
 

chrome/android/javatests/src/org/chromium/chrome/browser/banners/OWNERS

+dfalcantara@chromium.org