Commit e0fb4112 authored by Vadym Doroshenko's avatar Vadym Doroshenko Committed by Commit Bot

Additional logging for hash saving.

Bug: 994291
Change-Id: I48fe790dbf6c686e83264b638b0b031eb801d626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762239Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688605}
parent bb42fe06
...@@ -517,6 +517,12 @@ std::string SavePasswordProgressLogger::GetStringFromID( ...@@ -517,6 +517,12 @@ std::string SavePasswordProgressLogger::GetStringFromID(
case SavePasswordProgressLogger:: case SavePasswordProgressLogger::
STRING_PASSWORD_REQUIREMENTS_VOTE_NO_PASSWORD_ATTRIBUTES: STRING_PASSWORD_REQUIREMENTS_VOTE_NO_PASSWORD_ATTRIBUTES:
return "No password requirements attributed set"; return "No password requirements attributed set";
case STRING_SAVE_PASSWORD_HASH:
return "Password hash is saved";
case STRING_DID_NAVIGATE_MAIN_FRAME:
return "PasswordManager::DidNavigateMainFrame";
case STRING_NAVIGATION_NTP:
return "Navigation to New Tab page";
case SavePasswordProgressLogger::STRING_INVALID: case SavePasswordProgressLogger::STRING_INVALID:
return "INVALID"; return "INVALID";
// Intentionally no default: clause here -- all IDs need to get covered. // Intentionally no default: clause here -- all IDs need to get covered.
......
...@@ -191,6 +191,9 @@ class SavePasswordProgressLogger { ...@@ -191,6 +191,9 @@ class SavePasswordProgressLogger {
STRING_PASSWORD_REQUIREMENTS_VOTE_FOR_SPECIFIC_SPECIAL_SYMBOL, STRING_PASSWORD_REQUIREMENTS_VOTE_FOR_SPECIFIC_SPECIAL_SYMBOL,
STRING_PASSWORD_REQUIREMENTS_VOTE_FOR_PASSWORD_LENGTH, STRING_PASSWORD_REQUIREMENTS_VOTE_FOR_PASSWORD_LENGTH,
STRING_PASSWORD_REQUIREMENTS_VOTE_NO_PASSWORD_ATTRIBUTES, STRING_PASSWORD_REQUIREMENTS_VOTE_NO_PASSWORD_ATTRIBUTES,
STRING_SAVE_PASSWORD_HASH,
STRING_DID_NAVIGATE_MAIN_FRAME,
STRING_NAVIGATION_NTP,
STRING_INVALID, // Represents a string returned in a case of an error. STRING_INVALID, // Represents a string returned in a case of an error.
STRING_MAX = STRING_INVALID STRING_MAX = STRING_INVALID
}; };
......
...@@ -569,9 +569,19 @@ void PasswordManager::ProvisionallySavePassword( ...@@ -569,9 +569,19 @@ void PasswordManager::ProvisionallySavePassword(
} }
void PasswordManager::DidNavigateMainFrame(bool form_may_be_submitted) { void PasswordManager::DidNavigateMainFrame(bool form_may_be_submitted) {
std::unique_ptr<BrowserSavePasswordProgressLogger> logger;
if (password_manager_util::IsLoggingActive(client_)) {
logger.reset(
new BrowserSavePasswordProgressLogger(client_->GetLogManager()));
logger->LogBoolean(Logger::STRING_DID_NAVIGATE_MAIN_FRAME,
form_may_be_submitted);
}
pending_login_managers_.clear(); pending_login_managers_.clear();
if (client_->IsNewTabPage()) { if (client_->IsNewTabPage()) {
if (logger)
logger->LogMessage(Logger::STRING_NAVIGATION_NTP);
// On a successful Chrome sign-in the page navigates to the new tab page // On a successful Chrome sign-in the page navigates to the new tab page
// (ntp). OnPasswordFormsRendered is not called on ntp. That is why the // (ntp). OnPasswordFormsRendered is not called on ntp. That is why the
// standard flow for saving hash does not work. Save a password hash now // standard flow for saving hash does not work. Save a password hash now
...@@ -1293,6 +1303,11 @@ void PasswordManager::MaybeSavePasswordHash( ...@@ -1293,6 +1303,11 @@ void PasswordManager::MaybeSavePasswordHash(
if (!should_save_enterprise_pw && !should_save_gaia_pw) if (!should_save_enterprise_pw && !should_save_gaia_pw)
return; return;
if (password_manager_util::IsLoggingActive(client_)) {
BrowserSavePasswordProgressLogger logger(client_->GetLogManager());
logger.LogMessage(Logger::STRING_SAVE_PASSWORD_HASH);
}
// Canonicalizes username if it is an email. // Canonicalizes username if it is an email.
if (username.find('@') != std::string::npos) if (username.find('@') != std::string::npos)
username = gaia::CanonicalizeEmail(username); username = gaia::CanonicalizeEmail(username);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment