Remove "custom" field of runtime enabled features

The feature is not currently used anywhere. Also didn't find any usage
when we forked blink.

Change-Id: I2d84ab693b08075aaa39e57b2eddaffeb44c9b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104431
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750633}

third_party/blink/renderer/build/scripts/make_internal_runtime_flags.py

@@ -56,7 +56,6 @@ class InternalRuntimeFlagsWriter(
         return {
             'features': self._features,
             'input_files': self._input_files,
-            'standard_features': self._standard_features,
         }
 
     @template_expander.use_jinja('templates/internal_runtime_flags.h.tmpl')
@@ -65,7 +64,6 @@ class InternalRuntimeFlagsWriter(
             'features': self._features,
             'feature_sets': self._feature_sets(),
             'input_files': self._input_files,
-            'standard_features': self._standard_features,
             'header_guard': self._header_guard,
         }
 

third_party/blink/renderer/build/scripts/make_runtime_features.py

@@ -82,9 +82,6 @@ class BaseRuntimeFeatureWriter(json5_generator.Writer):
             feature['status_type'] = "dict" if isinstance(
                 feature['status'], dict) else "str"
 
-        self._standard_features = [
-            feature for feature in self._features if not feature['custom']
-        ]
         self._origin_trial_features = [
             feature for feature in self._features if feature['in_origin_trial']
         ]
@@ -158,7 +155,6 @@ class RuntimeFeatureWriter(BaseRuntimeFeatureWriter):
             'feature_sets': self._feature_sets(),
             'platforms': self._platforms(),
             'input_files': self._input_files,
-            'standard_features': self._standard_features,
             'origin_trial_controlled_features': self._origin_trial_features,
             'header_guard': self._header_guard,
         }
@@ -185,8 +181,7 @@ class RuntimeFeatureTestHelpersWriter(BaseRuntimeFeatureWriter):
 
     def _template_inputs(self):
         return {
-            # The test helpers don't support custom features.
-            'features': self._standard_features,
+            'features': self._features,
             'input_files': self._input_files,
             'header_guard': self._header_guard,
         }

third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.h.tmpl

@@ -25,13 +25,13 @@ class InternalRuntimeFlags : public ScriptWrappable {
 
   // These are reset between web tests from Internals::resetToConsistentState
   // using RuntimeEnabledFeatures::Backup.
-  {% for feature in standard_features if feature.settable_from_internals %}
+  {% for feature in features if feature.settable_from_internals %}
   void set{{feature.name}}Enabled(bool isEnabled) {
     RuntimeEnabledFeatures::Set{{feature.name}}Enabled(isEnabled);
   }
   {% endfor %}
 
-  {% for feature in standard_features %}
+  {% for feature in features %}
   bool {{feature.name.to_lower_camel_case()}}Enabled() {
     {% if feature.in_origin_trial %}
     return RuntimeEnabledFeatures::{{feature.name}}EnabledByRuntimeFlag();

third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.idl.tmpl

@@ -4,7 +4,7 @@
 {{source_files_for_generated_file(template_file, input_files)}}
 
 interface InternalRuntimeFlags {
-    {% for feature in standard_features %}
+    {% for feature in features %}
     {%+ if feature.condition %}[Conditional={{feature.condition}}] {% endif -%}
     {% if feature.settable_from_internals %}
     attribute boolean {{feature.name.to_lower_camel_case()}}Enabled;

third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.cc.tmpl

@@ -13,14 +13,14 @@
 namespace blink {
 
 RuntimeEnabledFeatures::Backup::Backup()
-  : {% for feature in standard_features -%}
+  : {% for feature in features -%}
     {{feature.data_member_name}}(RuntimeEnabledFeatures::{{feature.data_member_name}})
     {%- if not loop.last %},
     {%+ endif -%}
     {% endfor %} {}
 
 void RuntimeEnabledFeatures::Backup::Restore() {
-  {% for feature in standard_features %}
+  {% for feature in features %}
   RuntimeEnabledFeatures::{{feature.data_member_name}} = {{feature.data_member_name}};
   {% endfor %}
 }
@@ -67,7 +67,7 @@ void RuntimeEnabledFeatures::SetFeatureEnabledFromString(
     const char* name;
     bool* setting;
   } kFeatures[] = {
-  {% for feature in standard_features %}
+  {% for feature in features %}
     {"{{feature.name}}", &{{feature.data_member_name}}},
   {% endfor %}
   };
@@ -100,7 +100,7 @@ bool RuntimeEnabledFeatures::{{feature.name}}Enabled(const FeatureContext* conte
 
 {% endfor %}
 
-{% for feature in standard_features %}
+{% for feature in features %}
 {% if feature.status_type == 'str' %}
 bool RuntimeEnabledFeatures::{{feature.data_member_name}} = {{'true' if feature.status == 'stable' else 'false'}};
 {% endif %}
@@ -109,7 +109,7 @@ bool RuntimeEnabledFeatures::{{feature.data_member_name}} = {{'true' if feature.
 // Platform-dependent features
 {% for platform in platforms %}
 #if defined(OS_{{platform | upper}})
-{% for feature in standard_features %}
+{% for feature in features %}
 {% if feature.status_type == 'dict' %}
 bool RuntimeEnabledFeatures::{{feature.data_member_name}} = {{'true' if feature.status[platform] == 'stable' else 'false'}};
 {% endif %}
@@ -124,7 +124,7 @@ bool RuntimeEnabledFeatures::{{feature.data_member_name}} = {{'true' if feature.
  !defined(OS_{{platform | upper}})
 {%- endfor %}
 
-{% for feature in standard_features %}
+{% for feature in features %}
 {% if feature.status_type == 'dict' %}
 bool RuntimeEnabledFeatures::{{feature.data_member_name}} = {{'true' if feature.status['default'] == 'stable' else 'false'}};
 {% endif %}

third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.h.tmpl

@@ -48,7 +48,7 @@ class PLATFORM_EXPORT RuntimeEnabledFeatures {
     void Restore();
 
    private:
-    {% for feature in standard_features %}
+    {% for feature in features %}
     bool {{feature.data_member_name}};
     {% endfor %}
   };
@@ -62,13 +62,9 @@ class PLATFORM_EXPORT RuntimeEnabledFeatures {
 
   {% for feature in features %}
   {% if not feature.in_origin_trial %}
-  {% if feature.custom %}
-  static bool {{feature.name}}Enabled();
-  {% else %}
   static void Set{{feature.name}}Enabled(bool enabled) { {{feature.data_member_name}} = enabled; }
   static bool {{feature.name}}Enabled() { return {{feature.enabled_condition}}; }
   static bool {{feature.name}}Enabled(const FeatureContext*) { return {{feature.enabled_condition}}; }
-  {% endif %}
 
   {% endif %}
   {% endfor %}
@@ -84,12 +80,8 @@ class PLATFORM_EXPORT RuntimeEnabledFeatures {
   // feature is enabled in a given context.
 
   {% for feature in origin_trial_controlled_features %}
-  {% if feature.custom %}
-  static bool {{feature.name}}EnabledByRuntimeFlag();
-  {% else %}
   static void Set{{feature.name}}Enabled(bool enabled) { {{feature.data_member_name}} = enabled; }
   static bool {{feature.name}}EnabledByRuntimeFlag() { return {{feature.enabled_condition}}; }
-  {% endif %}
   static bool {{feature.name}}Enabled(const FeatureContext*);
 
   {% endfor %}
@@ -97,7 +89,7 @@ class PLATFORM_EXPORT RuntimeEnabledFeatures {
  private:
   friend class RuntimeEnabledFeaturesTestHelpers;
 
-  {% for feature in standard_features %}
+  {% for feature in features %}
   static bool {{feature.data_member_name}};
   {% endfor %}
 };

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -94,11 +94,6 @@
       valid_type: "bool",
     },
 
-    // Set to true to have customised {feature}Enabled() method implementation.
-    custom: {
-      valid_type: "bool",
-    },
-
     // Feature policy IDL extended attribute (see crrev.com/2247923004).
     feature_policy: {
     },