Commit e15527d2 authored by David Maunder's avatar David Maunder Committed by Commit Bot

Add assertion for tab.isInitialized()

To assist in the investigation of how uninitialized
Tabs are appearing in getDomain()

Bug: 1116613
Change-Id: Ia0ab0d7aca20d724fd1200b1fdbe1a2f951f9633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363485
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: default avatarYusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799482}
parent 64a6f220
...@@ -1336,6 +1336,7 @@ class TabListMediator { ...@@ -1336,6 +1336,7 @@ class TabListMediator {
protected static String getDomain(Tab tab) { protected static String getDomain(Tab tab) {
// TODO(crbug.com/1116613) Investigate how uninitialized Tabs are appearing // TODO(crbug.com/1116613) Investigate how uninitialized Tabs are appearing
// here. // here.
assert tab.isInitialized();
if (!tab.isInitialized()) { if (!tab.isInitialized()) {
return ""; return "";
} }
......
...@@ -2190,11 +2190,11 @@ public class TabListMediatorUnitTest { ...@@ -2190,11 +2190,11 @@ public class TabListMediatorUnitTest {
mCallbackCaptor.getValue().onResult(mFaviconDrawable); mCallbackCaptor.getValue().onResult(mFaviconDrawable);
} }
@Test @Test(expected = AssertionError.class)
public void testGetDomainOnDestroyedTab() { public void testGetDomainOnDestroyedTab() {
Tab tab = new MockTab(TAB1_ID, false); Tab tab = new MockTab(TAB1_ID, false);
tab.destroy(); tab.destroy();
assertEquals("", TabListMediator.getDomain(tab)); TabListMediator.getDomain(tab);
} }
private void initAndAssertAllProperties() { private void initAndAssertAllProperties() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment