Skip to content

GitLab

T
tangled
Commit e1674b04 authored by Thanh Le's avatar Thanh Le Committed by Commit Bot
Browse files
Options

Fix the layout of chrome://interventions-internals. 

The tab navigation bar is now stretch across the page The table also
fit to the device width, and the "URL" column in the "Logs" tab is now
scrollable to make it nicer for longer hostnames on mobile

Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3MlA2bnNYNUhfdVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3RXQ3clFLRFBtaVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3THd0Q3JVcm44c00

Bug: 764419
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieba316275f2acfa60dea480be701995c68fb2f7a
Reviewed-on: https://chromium-review.googlesource.com/747865Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513026}
parent 18360517
Hide whitespace changes
Inline Side-by-side
Showing with 37 additions and 9 deletions
chrome/browser/resources/interventions_internals/index.css
View file @ e1674b04
......@@ -14,43 +14,71 @@
padding: 12px;
}
.tab-select {
left:0;
right:0;
}
.tab-select input[type=radio] {
display: none;
display: none;
}
.tab-select label {
background: #ddd;
border: outset 1px silver;
cursor: pointer;
margin-right: -5px;
display: table-cell;
padding: 5px 5px;
text-align: center;
vertical-align: middle;
width: 20%;
}
.tab-select input:checked + span {
background: #aaa;
border: inset 1px silver;
display: table-cell;
height: 2em;
text-align: center;
vertical-align: middle;
width: 30em;
}
.table-name {
font-size: 100%;
font-weight: bold;
margin-top: 10px;
}
table {
border: 1px solid black;
border: 0;
border-collapse: collapse;
margin-top: 10px;
max-height: 100px;
table-layout: fixed;
width: 100%;
}
th {
td {
border: 1px solid black;
padding: 15px;
padding: 10px;
text-align: left;
}
td {
td.log-time {
word-wrap: break-word;
}
td.log-url {
overflow: scroll;
text-overflow: scroll;
}
th {
border: 1px solid black;
padding: 15px;
text-align: left;
text-align: center;
}
.error-header {
......
chrome/browser/resources/interventions_internals/index.html
View file @ e1674b04
......@@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Interventions-Internals</title>
<script src="chrome://resources/js/cr.js"></script>
<script src="chrome://resources/js/mojo_bindings.js"></script>
......@@ -31,7 +31,7 @@
</label>
<label>
<input type="radio" id="nqe-tab" name="tabs" value="nqe-info">
<span>Network Quality Estimator</span>
<span>Network Quality</span>
</label>
</nav>
......@@ -46,7 +46,7 @@
<tr>
<th id="time-table-header">Time</th>
<th id="type-table-header">Type</th>
<th id="description-table-header">Description</th>
<th id="description-table-header">Notes</th>
<th id="url-table-header">URL</th>
</tr>
</table>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment