Commit e183428a authored by kylechar's avatar kylechar Committed by Commit Bot

Revert "Add aliased variables for GPU failure browser crashes."

This reverts commit 718282e6.

Reason for revert: Added for debugging purposes and no longer needed.

Original change's description:
> Add aliased variables for GPU failure browser crashes.
> 
> This CL saves some state in local variables and aliases them for
> inclusion in crash minidumps. This information will help diagnose GPU
> process failures with OOP-D and the resulting browser crash when we
> can't launch a GPU process.
> 
> Bug: 849639
> Change-Id: Id5a65c428eff83c80208b53081083d4feaf26063
> Reviewed-on: https://chromium-review.googlesource.com/1138178
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575294}

TBR=backer@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 849639
Change-Id: I09f1e28b6ccad89bde6a38139787a3e218d01d62
Reviewed-on: https://chromium-review.googlesource.com/1206697Reviewed-by: default avatarJonathan Backer <backer@chromium.org>
Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588925}
parent 21e98d19
...@@ -15,7 +15,6 @@ ...@@ -15,7 +15,6 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/callback_helpers.h" #include "base/callback_helpers.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/debug/alias.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
...@@ -983,11 +982,6 @@ void GpuProcessHost::OnProcessLaunched() { ...@@ -983,11 +982,6 @@ void GpuProcessHost::OnProcessLaunched() {
} }
void GpuProcessHost::OnProcessLaunchFailed(int error_code) { void GpuProcessHost::OnProcessLaunchFailed(int error_code) {
// TODO(crbug.com/849639): Ensure |error_code| is included in crash minidumps.
// This is for debugging and should be removed when bug is closed.
int process_launch_error_code = error_code;
base::debug::Alias(&process_launch_error_code);
#if defined(OS_WIN) #if defined(OS_WIN)
if (kind_ == GPU_PROCESS_KIND_SANDBOXED) if (kind_ == GPU_PROCESS_KIND_SANDBOXED)
RecordAppContainerStatus(error_code, crashed_before_); RecordAppContainerStatus(error_code, crashed_before_);
...@@ -996,11 +990,6 @@ void GpuProcessHost::OnProcessLaunchFailed(int error_code) { ...@@ -996,11 +990,6 @@ void GpuProcessHost::OnProcessLaunchFailed(int error_code) {
} }
void GpuProcessHost::OnProcessCrashed(int exit_code) { void GpuProcessHost::OnProcessCrashed(int exit_code) {
// TODO(crbug.com/849639): Ensure |exit_code| is included in crash minidumps.
// This is for debugging and should be removed when bug is closed.
int process_crash_exit_code = exit_code;
base::debug::Alias(&process_crash_exit_code);
// Record crash before doing anything that could start a new GPU process. // Record crash before doing anything that could start a new GPU process.
RecordProcessCrash(); RecordProcessCrash();
...@@ -1268,16 +1257,6 @@ void GpuProcessHost::RecordProcessCrash() { ...@@ -1268,16 +1257,6 @@ void GpuProcessHost::RecordProcessCrash() {
recent_crash_count = display_compositor_recent_crash_count_; recent_crash_count = display_compositor_recent_crash_count_;
} }
// TODO(crbug.com/849639): Ensure crash counts are included in crash
// minidumps. This is for debugging and should be removed when bug is closed.
int hardware_accelerated_crash_count =
hardware_accelerated_recent_crash_count_;
base::debug::Alias(&hardware_accelerated_crash_count);
int swiftshader_crash_count = swiftshader_recent_crash_count_;
base::debug::Alias(&swiftshader_crash_count);
int display_compositor_crash_count = display_compositor_recent_crash_count_;
base::debug::Alias(&display_compositor_crash_count);
// GPU process initialization failed and fallback already happened. // GPU process initialization failed and fallback already happened.
if (!gpu_host_ || !gpu_host_->initialized()) if (!gpu_host_ || !gpu_host_->initialized())
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment