Commit e1ac5162 authored by Charles Zhao's avatar Charles Zhao Committed by Commit Bot

Turn tabdiscarder off.

This will stop TabManagerDelete to call TabActivityWatcher, hence
disable tabdiscarder completely.

Note: we can still do experiment from Finch.

Bug: 1017222
Change-Id: I064004ae6e0e67d2df0133c98626c395db73f6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888863
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Reviewed-by: default avatarCharles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710830}
parent 379b2bc4
...@@ -109,7 +109,9 @@ TEST_F(TabManagerDelegateTest, CandidatesSortedWithFocusedAppAndTab) { ...@@ -109,7 +109,9 @@ TEST_F(TabManagerDelegateTest, CandidatesSortedWithFocusedAppAndTab) {
// is turned on. // is turned on.
TEST_F(TabManagerDelegateTest, SortLifecycleUnitWithTabRanker) { TEST_F(TabManagerDelegateTest, SortLifecycleUnitWithTabRanker) {
base::test::ScopedFeatureList feature_list; base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(features::kTabRanker); feature_list.InitAndEnableFeatureWithParameters(
features::kTabRanker,
{{"number_of_oldest_tabs_to_score_with_TabRanker", "20"}});
std::vector<arc::ArcProcess> arc_processes; std::vector<arc::ArcProcess> arc_processes;
arc_processes.emplace_back(1, 10, "focused", arc::mojom::ProcessState::TOP, arc_processes.emplace_back(1, 10, "focused", arc::mojom::ProcessState::TOP,
kIsFocused, 99); kIsFocused, 99);
......
...@@ -257,8 +257,7 @@ GetStaticSiteCharacteristicsDatabaseParams() { ...@@ -257,8 +257,7 @@ GetStaticSiteCharacteristicsDatabaseParams() {
int GetNumOldestTabsToScoreWithTabRanker() { int GetNumOldestTabsToScoreWithTabRanker() {
return base::GetFieldTrialParamByFeatureAsInt( return base::GetFieldTrialParamByFeatureAsInt(
features::kTabRanker, "number_of_oldest_tabs_to_score_with_TabRanker", features::kTabRanker, "number_of_oldest_tabs_to_score_with_TabRanker", 0);
20);
} }
int GetProcessTypeToScoreWithTabRanker() { int GetProcessTypeToScoreWithTabRanker() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment