Skip to content

GitLab

T
tangled
Commit e1bc0645 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot
Browse files
Options

Make GPU Gold tests non-experimental 

Makes the Skia Gold version of the GPU pixel tests non-experimental, so
any unsuppressed failures will show up as builder-level failures since
the tests have been quite stable.

Documentation on Gold and how to triage any new images the tests produce
can be found at
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gpu/gpu_pixel_testing_with_gold.md

Bug: 850107
Change-Id: Ic7187f049f98bad561d8591e04354359fe64e4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698644Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677067}
parent ee0c3ba0
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 59 deletions
testing/buildbot/chromium.gpu.fyi.json
View file @ e1bc0645
...@@ -3735,7 +3735,6 @@ ...@@ -3735,7 +3735,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -4300,7 +4299,6 @@ ...@@ -4300,7 +4299,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -4849,7 +4847,6 @@ ...@@ -4849,7 +4847,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -5441,7 +5438,6 @@ ...@@ -5441,7 +5438,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -6078,7 +6074,6 @@ ...@@ -6078,7 +6074,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -6672,7 +6667,6 @@ ...@@ -6672,7 +6667,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -6873,7 +6867,6 @@ ...@@ -6873,7 +6867,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -8063,7 +8056,6 @@ ...@@ -8063,7 +8056,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -8673,7 +8665,6 @@ ...@@ -8673,7 +8665,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -9463,7 +9454,6 @@ ...@@ -9463,7 +9454,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -10354,7 +10344,6 @@ ...@@ -10354,7 +10344,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -10953,7 +10942,6 @@ ...@@ -10953,7 +10942,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -11603,7 +11591,6 @@ ...@@ -11603,7 +11591,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -13020,7 +13007,6 @@ ...@@ -13020,7 +13007,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -13896,7 +13882,6 @@ ...@@ -13896,7 +13882,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -14772,7 +14757,6 @@ ...@@ -14772,7 +14757,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -15414,7 +15398,6 @@ ...@@ -15414,7 +15398,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -15976,7 +15959,6 @@ ...@@ -15976,7 +15959,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -16595,7 +16577,6 @@ ...@@ -16595,7 +16577,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -17220,7 +17201,6 @@ ...@@ -17220,7 +17201,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -17873,7 +17853,6 @@ ...@@ -17873,7 +17853,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -18493,7 +18472,6 @@ ...@@ -18493,7 +18472,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -19099,7 +19077,6 @@ ...@@ -19099,7 +19077,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -19664,7 +19641,6 @@ ...@@ -19664,7 +19641,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -20224,7 +20200,6 @@ ...@@ -20224,7 +20200,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -20870,7 +20845,6 @@ ...@@ -20870,7 +20845,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -21610,7 +21584,6 @@ ...@@ -21610,7 +21584,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -21959,7 +21932,6 @@ ...@@ -21959,7 +21932,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -22253,7 +22225,6 @@ ...@@ -22253,7 +22225,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -22552,7 +22523,6 @@ ...@@ -22552,7 +22523,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -22811,7 +22781,6 @@ ...@@ -22811,7 +22781,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -23411,7 +23380,6 @@ ...@@ -23411,7 +23380,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -24167,7 +24135,6 @@ ...@@ -24167,7 +24135,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -25125,7 +25092,6 @@ ...@@ -25125,7 +25092,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -26056,7 +26022,6 @@ ...@@ -26056,7 +26022,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -27096,7 +27061,6 @@ ...@@ -27096,7 +27061,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -28016,7 +27980,6 @@ ...@@ -28016,7 +27980,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -29104,7 +29067,6 @@ ...@@ -29104,7 +29067,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -30366,7 +30328,6 @@ ...@@ -30366,7 +30328,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -32229,7 +32190,6 @@ ...@@ -32229,7 +32190,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -33083,7 +33043,6 @@ ...@@ -33083,7 +33043,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -34168,7 +34127,6 @@ ...@@ -34168,7 +34127,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -35470,7 +35428,6 @@ ...@@ -35470,7 +35428,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
testing/buildbot/chromium.gpu.json
View file @ e1bc0645
...@@ -213,7 +213,6 @@ ...@@ -213,7 +213,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -672,7 +671,6 @@ ...@@ -672,7 +671,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -1117,7 +1115,6 @@ ...@@ -1117,7 +1115,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -1571,7 +1568,6 @@ ...@@ -1571,7 +1568,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_coverage_data": true, "isolate_coverage_data": true,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
...@@ -2010,7 +2006,6 @@ ...@@ -2010,7 +2006,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -2463,7 +2458,6 @@ ...@@ -2463,7 +2458,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -2910,7 +2904,6 @@ ...@@ -2910,7 +2904,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -3393,7 +3386,6 @@ ...@@ -3393,7 +3386,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -3910,7 +3902,6 @@ ...@@ -3910,7 +3902,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -4564,7 +4555,6 @@ ...@@ -4564,7 +4555,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
......
testing/buildbot/client.v8.fyi.json
View file @ e1bc0645
...@@ -174,7 +174,6 @@ ...@@ -174,7 +174,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -543,7 +542,6 @@ ...@@ -543,7 +542,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -906,7 +904,6 @@ ...@@ -906,7 +904,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -1264,7 +1261,6 @@ ...@@ -1264,7 +1261,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
...@@ -1726,7 +1722,6 @@ ...@@ -1726,7 +1722,6 @@
"${buildername}", "${buildername}",
"--use-skia-gold" "--use-skia-gold"
], ],
"experiment_percentage": 100,
"isolate_name": "telemetry_gpu_integration_test", "isolate_name": "telemetry_gpu_integration_test",
"merge": { "merge": {
"args": [], "args": [],
......
testing/buildbot/test_suites.pyl
View file @ e1bc0645
...@@ -3714,7 +3714,6 @@ ...@@ -3714,7 +3714,6 @@
'--buildbucket-build-id', '--buildbucket-build-id',
'${buildbucket_build_id}', '${buildbucket_build_id}',
], ],
'experiment_percentage': 100,
'swarming': { 'swarming': {
'service_account': 'chrome-gpu-gold@chops-service-accounts.iam.gserviceaccount.com' 'service_account': 'chrome-gpu-gold@chops-service-accounts.iam.gserviceaccount.com'
}, },
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment