Commit e1bce6c3 authored by Andy Paicu's avatar Andy Paicu Committed by Commit Bot

Disabled 22 failing Audio tests

TBR=olka@chromium.org

Bug: 1060165
Change-Id: I0f96c85b400ea05dd0bfbd9852d99b029cfdec02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096758Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748706}
parent 211170d2
...@@ -173,47 +173,36 @@ class AudioInputTest : public testing::Test { ...@@ -173,47 +173,36 @@ class AudioInputTest : public testing::Test {
}; };
// Test create and close of an AudioInputStream without recording audio. // Test create and close of an AudioInputStream without recording audio.
TEST_F(AudioInputTest, CreateAndClose) { // Disabled: crbug.com/1060165
TEST_F(AudioInputTest, DISABLED_CreateAndClose) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
MakeAudioInputStreamOnAudioThread(); MakeAudioInputStreamOnAudioThread();
CloseAudioInputStreamOnAudioThread(); CloseAudioInputStreamOnAudioThread();
} }
#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
// This test is failing on ARM linux: http://crbug.com/238490
#define MAYBE_OpenAndClose DISABLED_OpenAndClose
#else
#define MAYBE_OpenAndClose OpenAndClose
#endif
// Test create, open and close of an AudioInputStream without recording audio. // Test create, open and close of an AudioInputStream without recording audio.
TEST_F(AudioInputTest, MAYBE_OpenAndClose) { // This test is failing on ARM linux: http://crbug.com/238490
// Disabled: crbug.com/1060165
TEST_F(AudioInputTest, DISABLED_OpenAndClose) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
MakeAudioInputStreamOnAudioThread(); MakeAudioInputStreamOnAudioThread();
OpenAndCloseAudioInputStreamOnAudioThread(); OpenAndCloseAudioInputStreamOnAudioThread();
} }
#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
// This test is failing on ARM linux: http://crbug.com/238490
#define MAYBE_OpenStopAndClose DISABLED_OpenStopAndClose
#else
#define MAYBE_OpenStopAndClose OpenStopAndClose
#endif
// Test create, open, stop and close of an AudioInputStream without recording. // Test create, open, stop and close of an AudioInputStream without recording.
TEST_F(AudioInputTest, MAYBE_OpenStopAndClose) { // This test is failing on ARM linux: http://crbug.com/238490
// Disabled: crbug.com/1060165
TEST_F(AudioInputTest, DISABLED_OpenStopAndClose) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
MakeAudioInputStreamOnAudioThread(); MakeAudioInputStreamOnAudioThread();
OpenStopAndCloseAudioInputStreamOnAudioThread(); OpenStopAndCloseAudioInputStreamOnAudioThread();
} }
#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
// This test is failing on ARM linux: http://crbug.com/238490
#define MAYBE_Record DISABLED_Record
#else
#define MAYBE_Record Record
#endif
// Test a normal recording sequence using an AudioInputStream. // Test a normal recording sequence using an AudioInputStream.
// Very simple test which starts capturing and verifies that recording starts. // Very simple test which starts capturing and verifies that recording starts.
TEST_F(AudioInputTest, MAYBE_Record) { // This test is failing on ARM linux: http://crbug.com/238490
// Disabled: crbug.com/1060165
TEST_F(AudioInputTest, DISABLED_Record) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
MakeAudioInputStreamOnAudioThread(); MakeAudioInputStreamOnAudioThread();
......
...@@ -457,7 +457,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesCras) { ...@@ -457,7 +457,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesCras) {
} }
#else // !defined(USE_CRAS) #else // !defined(USE_CRAS)
TEST_F(AudioManagerTest, HandleDefaultDeviceIDs) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_HandleDefaultDeviceIDs) {
// Use a fake manager so we can makeup device ids, this will still use the // Use a fake manager so we can makeup device ids, this will still use the
// AudioManagerBase code. // AudioManagerBase code.
CreateAudioManagerForTesting<FakeAudioManager>(); CreateAudioManagerForTesting<FakeAudioManager>();
...@@ -466,7 +467,8 @@ TEST_F(AudioManagerTest, HandleDefaultDeviceIDs) { ...@@ -466,7 +467,8 @@ TEST_F(AudioManagerTest, HandleDefaultDeviceIDs) {
} }
// Test that devices can be enumerated. // Test that devices can be enumerated.
TEST_F(AudioManagerTest, EnumerateInputDevices) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_EnumerateInputDevices) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
AudioDeviceDescriptions device_descriptions; AudioDeviceDescriptions device_descriptions;
...@@ -475,7 +477,8 @@ TEST_F(AudioManagerTest, EnumerateInputDevices) { ...@@ -475,7 +477,8 @@ TEST_F(AudioManagerTest, EnumerateInputDevices) {
} }
// Test that devices can be enumerated. // Test that devices can be enumerated.
TEST_F(AudioManagerTest, EnumerateOutputDevices) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_EnumerateOutputDevices) {
ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable());
AudioDeviceDescriptions device_descriptions; AudioDeviceDescriptions device_descriptions;
...@@ -512,7 +515,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesWinMMDevice) { ...@@ -512,7 +515,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesWinMMDevice) {
// sometimes be tested on a single system. These tests specifically // sometimes be tested on a single system. These tests specifically
// test Pulseaudio. // test Pulseaudio.
TEST_F(AudioManagerTest, EnumerateInputDevicesPulseaudio) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_EnumerateInputDevicesPulseaudio) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
CreateAudioManagerForTesting<AudioManagerPulse>(); CreateAudioManagerForTesting<AudioManagerPulse>();
...@@ -526,7 +530,8 @@ TEST_F(AudioManagerTest, EnumerateInputDevicesPulseaudio) { ...@@ -526,7 +530,8 @@ TEST_F(AudioManagerTest, EnumerateInputDevicesPulseaudio) {
} }
} }
TEST_F(AudioManagerTest, EnumerateOutputDevicesPulseaudio) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_EnumerateOutputDevicesPulseaudio) {
ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable());
CreateAudioManagerForTesting<AudioManagerPulse>(); CreateAudioManagerForTesting<AudioManagerPulse>();
...@@ -546,7 +551,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesPulseaudio) { ...@@ -546,7 +551,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesPulseaudio) {
// sometimes be tested on a single system. These tests specifically // sometimes be tested on a single system. These tests specifically
// test Alsa. // test Alsa.
TEST_F(AudioManagerTest, EnumerateInputDevicesAlsa) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_EnumerateInputDevicesAlsa) {
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
DVLOG(2) << "Testing AudioManagerAlsa."; DVLOG(2) << "Testing AudioManagerAlsa.";
...@@ -556,7 +562,8 @@ TEST_F(AudioManagerTest, EnumerateInputDevicesAlsa) { ...@@ -556,7 +562,8 @@ TEST_F(AudioManagerTest, EnumerateInputDevicesAlsa) {
CheckDeviceDescriptions(device_descriptions); CheckDeviceDescriptions(device_descriptions);
} }
TEST_F(AudioManagerTest, EnumerateOutputDevicesAlsa) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_EnumerateOutputDevicesAlsa) {
ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable());
DVLOG(2) << "Testing AudioManagerAlsa."; DVLOG(2) << "Testing AudioManagerAlsa.";
...@@ -567,7 +574,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesAlsa) { ...@@ -567,7 +574,8 @@ TEST_F(AudioManagerTest, EnumerateOutputDevicesAlsa) {
} }
#endif // defined(USE_ALSA) #endif // defined(USE_ALSA)
TEST_F(AudioManagerTest, GetDefaultOutputStreamParameters) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_GetDefaultOutputStreamParameters) {
#if defined(OS_WIN) || defined(OS_MACOSX) #if defined(OS_WIN) || defined(OS_MACOSX)
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
...@@ -577,7 +585,8 @@ TEST_F(AudioManagerTest, GetDefaultOutputStreamParameters) { ...@@ -577,7 +585,8 @@ TEST_F(AudioManagerTest, GetDefaultOutputStreamParameters) {
#endif // defined(OS_WIN) || defined(OS_MACOSX) #endif // defined(OS_WIN) || defined(OS_MACOSX)
} }
TEST_F(AudioManagerTest, GetAssociatedOutputDeviceID) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_GetAssociatedOutputDeviceID) {
#if defined(OS_WIN) || defined(OS_MACOSX) #if defined(OS_WIN) || defined(OS_MACOSX)
ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable() && OutputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable() && OutputDevicesAvailable());
...@@ -653,7 +662,8 @@ class TestAudioManager : public FakeAudioManager { ...@@ -653,7 +662,8 @@ class TestAudioManager : public FakeAudioManager {
} }
}; };
TEST_F(AudioManagerTest, GroupId) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest, DISABLED_GroupId) {
CreateAudioManagerForTesting<TestAudioManager>(); CreateAudioManagerForTesting<TestAudioManager>();
// Groups: // Groups:
// input1, output1 // input1, output1
...@@ -688,7 +698,9 @@ TEST_F(AudioManagerTest, GroupId) { ...@@ -688,7 +698,9 @@ TEST_F(AudioManagerTest, GroupId) {
EXPECT_NE(outputs[2].group_id, outputs[3].group_id); EXPECT_NE(outputs[2].group_id, outputs[3].group_id);
} }
TEST_F(AudioManagerTest, DefaultCommunicationsLabelsContainRealLabels) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest,
DISABLED_DefaultCommunicationsLabelsContainRealLabels) {
CreateAudioManagerForTesting<TestAudioManager>(); CreateAudioManagerForTesting<TestAudioManager>();
std::string default_input_id = std::string default_input_id =
device_info_accessor_->GetDefaultInputDeviceID(); device_info_accessor_->GetDefaultInputDeviceID();
...@@ -713,7 +725,9 @@ TEST_F(AudioManagerTest, DefaultCommunicationsLabelsContainRealLabels) { ...@@ -713,7 +725,9 @@ TEST_F(AudioManagerTest, DefaultCommunicationsLabelsContainRealLabels) {
// GetPreferredOutputStreamParameters() can make changes to its input_params, // GetPreferredOutputStreamParameters() can make changes to its input_params,
// ensure that creating a stream with the default parameters always works. // ensure that creating a stream with the default parameters always works.
TEST_F(AudioManagerTest, CheckMakeOutputStreamWithPreferredParameters) { // Disabled: crbug.com/1060165
TEST_F(AudioManagerTest,
DISABLED_CheckMakeOutputStreamWithPreferredParameters) {
ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable()); ABORT_AUDIO_TEST_IF_NOT(OutputDevicesAvailable());
AudioParameters params; AudioParameters params;
......
...@@ -75,14 +75,16 @@ class AudioOutputTest : public testing::TestWithParam<bool> { ...@@ -75,14 +75,16 @@ class AudioOutputTest : public testing::TestWithParam<bool> {
}; };
// Test that can it be created and closed. // Test that can it be created and closed.
TEST_P(AudioOutputTest, GetAndClose) { // Disabled: crbug.com/1060165
TEST_P(AudioOutputTest, DISABLED_GetAndClose) {
ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices()); ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
CreateWithDefaultParameters(); CreateWithDefaultParameters();
ASSERT_TRUE(stream_); ASSERT_TRUE(stream_);
} }
// Test that it can be opened and closed. // Test that it can be opened and closed.
TEST_P(AudioOutputTest, OpenAndClose) { // Disabled: crbug.com/1060165
TEST_P(AudioOutputTest, DISABLED_OpenAndClose) {
ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices()); ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
CreateWithDefaultParameters(); CreateWithDefaultParameters();
...@@ -91,7 +93,8 @@ TEST_P(AudioOutputTest, OpenAndClose) { ...@@ -91,7 +93,8 @@ TEST_P(AudioOutputTest, OpenAndClose) {
} }
// Verify that Stop() can be called before Start(). // Verify that Stop() can be called before Start().
TEST_P(AudioOutputTest, StopBeforeStart) { // Disabled: crbug.com/1060165
TEST_P(AudioOutputTest, DISABLED_StopBeforeStart) {
ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices()); ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
CreateWithDefaultParameters(); CreateWithDefaultParameters();
EXPECT_TRUE(stream_->Open()); EXPECT_TRUE(stream_->Open());
...@@ -99,7 +102,8 @@ TEST_P(AudioOutputTest, StopBeforeStart) { ...@@ -99,7 +102,8 @@ TEST_P(AudioOutputTest, StopBeforeStart) {
} }
// Verify that Stop() can be called more than once. // Verify that Stop() can be called more than once.
TEST_P(AudioOutputTest, StopTwice) { // Disabled: crbug.com/1060165
TEST_P(AudioOutputTest, DISABLED_StopTwice) {
ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices()); ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
CreateWithDefaultParameters(); CreateWithDefaultParameters();
EXPECT_TRUE(stream_->Open()); EXPECT_TRUE(stream_->Open());
...@@ -111,7 +115,8 @@ TEST_P(AudioOutputTest, StopTwice) { ...@@ -111,7 +115,8 @@ TEST_P(AudioOutputTest, StopTwice) {
} }
// This test produces actual audio for .25 seconds on the default device. // This test produces actual audio for .25 seconds on the default device.
TEST_P(AudioOutputTest, Play200HzTone) { // Disabled: crbug.com/1060165
TEST_P(AudioOutputTest, DISABLED_Play200HzTone) {
ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices()); ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
stream_params_ = stream_params_ =
...@@ -149,7 +154,8 @@ TEST_P(AudioOutputTest, Play200HzTone) { ...@@ -149,7 +154,8 @@ TEST_P(AudioOutputTest, Play200HzTone) {
} }
// Test that SetVolume() and GetVolume() work as expected. // Test that SetVolume() and GetVolume() work as expected.
TEST_P(AudioOutputTest, VolumeControl) { // Disabled: crbug.com/1060165
TEST_P(AudioOutputTest, DISABLED_VolumeControl) {
ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices()); ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
CreateWithDefaultParameters(); CreateWithDefaultParameters();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment